From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752769AbdCGHdh (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 02:33:37 -0500
Received: from mail-wr0-f193.google.com ([209.85.128.193]:34858 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750824AbdCGHd1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 02:33:27 -0500
Date: Tue, 7 Mar 2017 08:23:22 +0100
From: Ingo Molnar <mingo@kernel.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Rik van Riel <riel@redhat.com>, kbuild-all@01.org,
        linux-kernel@vger.kernel.org, tipbuild@zytor.com,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
        Yu-cheng Yu <yu-cheng.yu@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings
Message-ID: <20170307072322.GB29708@gmail.com>
References: <201703060848.Q2LHSMc4%fengguang.wu@intel.com>
 <20170306004553.GA25764@lkp-wsm-ep1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170306004553.GA25764@lkp-wsm-ep1>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* kbuild test robot <fengguang.wu@intel.com> wrote:

> arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function 'xfeatures_mxcsr_quirk' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.

Note that this is a totally bogus warning. I personally find a 0/1 return more 
readable than a textual 'true/false', even if bools are used, and nowhere does the 
kernel mandate the use of 0/1.

So NAK ...

Thanks,

	Ingo