From: Ingo Molnar <mingo@kernel.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Include asm/ptrace.h now linux/sched.h doesn't
Date: Tue, 7 Mar 2017 08:44:51 +0100 [thread overview]
Message-ID: <20170307074451.GB24782@gmail.com> (raw)
In-Reply-To: <0cd2d2c571afea9658428ee251ae5d3325bfe01b.1488587471.git-series.james.hogan@imgtec.com>
* James Hogan <james.hogan@imgtec.com> wrote:
> Use of the task_pt_regs() based macros in MIPS' asm/processor.h for
> accessing the user context on the kernel stack need the definition of
> struct pt_regs from asm/ptrace.h. __own_fpu() in asm/fpu.h uses these
> macros but implicitly depended on linux/sched.h to include asm/ptrace.h.
>
> Since commit f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from
> <linux/sched.h>") however linux/sched.h no longer includes asm/ptrace.h,
> so include it explicitly from asm/fpu.h where it is needed instead.
>
> This fixes build errors such as:
>
> ./arch/mips/include/asm/fpu.h: In function '__own_fpu':
> ./arch/mips/include/asm/processor.h:385:31: error: invalid application of 'sizeof' to incomplete type 'struct pt_regs'
> THREAD_SIZE - 32 - sizeof(struct pt_regs))
> ^
>
> Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from <linux/sched.h>")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: linux-mips@linux-mips.org
My build tests missed this bug, thanks James!
Acked-by: Ingo Molnar <mingo@kernel.org>
Ingo
prev parent reply other threads:[~2017-03-07 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 0:32 [PATCH] MIPS: Include asm/ptrace.h now linux/sched.h doesn't James Hogan
2017-03-04 0:32 ` James Hogan
2017-03-07 7:44 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307074451.GB24782@gmail.com \
--to=mingo@kernel.org \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.