From: Jan Kara <jack@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: jack@suse.cz, ceph-devel@vger.kernel.org
Subject: Re: [bug report] block: Move bdi_unregister() to del_gendisk()
Date: Tue, 7 Mar 2017 11:54:56 +0100 [thread overview]
Message-ID: <20170307105456.GD2578@quack2.suse.cz> (raw)
In-Reply-To: <20170307102401.GA4120@mwanda>
On Tue 07-03-17 13:24:55, Dan Carpenter wrote:
> Also:
>
> arch/powerpc/sysdev/axonram.c:277 axon_ram_probe()
> error: we previously assumed 'bank->disk->queue' could be null (see line 231)
So this is real however the error path of axon_ram_probe() looks hosed. You
are not supposed to call del_gendisk() if you did not call
device_add_disk() before and axon_ram_probe() leaks the gendisk structure
because it forgets to call put_disk(). I'll look into fixing this.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-03-07 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 0:13 [bug report] block: Move bdi_unregister() to del_gendisk() Dan Carpenter
2017-03-07 10:24 ` Dan Carpenter
2017-03-07 10:54 ` Jan Kara [this message]
2017-03-07 10:44 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307105456.GD2578@quack2.suse.cz \
--to=jack@suse.cz \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.