From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pascal Mazon <pascal.mazon@6wind.com>
Subject: Re: [PATCH v2 0/4] net/tap: support flow API
Date: Tue, 7 Mar 2017 16:05:19 +0100
Message-ID: <20170307160519.6b8ff31b@paques.dev.6wind.com>
References: <cover.1488537600.git.pascal.mazon@6wind.com>
 <cover.1488819791.git.pascal.mazon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: keith.wiles@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 5A119108A
 for <dev@dpdk.org>; Tue,  7 Mar 2017 16:05:36 +0100 (CET)
Received: by mail-wm0-f45.google.com with SMTP id n11so92060536wma.1
 for <dev@dpdk.org>; Tue, 07 Mar 2017 07:05:36 -0800 (PST)
In-Reply-To: <cover.1488819791.git.pascal.mazon@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Keith,

I'm working on a v3 for that series:

- I added info regarding flow API support in tap.rst doc
- I fixed support for kernels where flower/vlan was not supported.

Do you have any other remarks, or can I send the v3 (hopefully ok for
integration)?

I'll send a v2 for the latest series (introducing remote capture),
because struct pmd_internals changed (whitespaces).
Same question there, do you have remarks?

Thank you.

Best regards,
Pascal

On Mon,  6 Mar 2017 18:05:26 +0100
Pascal Mazon <pascal.mazon@6wind.com> wrote:

> This series add support for the flow API in tap PMD.
> 
> It enables filtering specific packets incoming on the tap netdevice,
> to process only desired ones. Under the hood, it uses kernel TC
> (traffic control), which takes place very early in the stack, and
> supports most common pattern items and actions defined in the flow
> API.
> 
> This series applies on top of:
> 
>   [PATCH 0/6] net/tap: add additional management ops
> 
> v2 changes:
>   - support compilation on kernels < 4.2 (where flower support
> appeared)
>   - set whitespaces in tap.h
>   - remove unnecessary goto
> 
> Pascal Mazon (4):
>   net/tap: move private elements to external header
>   net/tap: add preliminary support for rte_flow
>   net/tap: add netlink back-end for flow API
>   net/tap: add basic flow API patterns and actions
> 
>  doc/guides/nics/features/tap.ini |    1 +
>  drivers/net/tap/Makefile         |   44 ++
>  drivers/net/tap/rte_eth_tap.c    |   94 ++--
>  drivers/net/tap/tap.h            |   77 +++
>  drivers/net/tap/tap_flow.c       | 1084
> ++++++++++++++++++++++++++++++++++++++
> drivers/net/tap/tap_flow.h       |   58 ++
> drivers/net/tap/tap_netlink.c    |  367 +++++++++++++
> drivers/net/tap/tap_netlink.h    |   69 +++
> drivers/net/tap/tap_tcmsgs.c     |  378 +++++++++++++
> drivers/net/tap/tap_tcmsgs.h     |   63 +++ 10 files changed, 2202
> insertions(+), 33 deletions(-) create mode 100644
> drivers/net/tap/tap.h create mode 100644 drivers/net/tap/tap_flow.c
>  create mode 100644 drivers/net/tap/tap_flow.h
>  create mode 100644 drivers/net/tap/tap_netlink.c
>  create mode 100644 drivers/net/tap/tap_netlink.h
>  create mode 100644 drivers/net/tap/tap_tcmsgs.c
>  create mode 100644 drivers/net/tap/tap_tcmsgs.h
>