From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] extensions: libxt_conntrack: Fix 'state' translation to nft
Date: Tue, 7 Mar 2017 17:20:55 +0100 [thread overview]
Message-ID: <20170307162055.GA4753@salvia> (raw)
In-Reply-To: <20170307161729.GA2233@salvia>
On Tue, Mar 07, 2017 at 05:17:29PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Mar 07, 2017 at 04:35:07PM +0100, Phil Sutter wrote:
> > While translating a conntrack state match in old syntax, matches are
> > looked up by name, only. This returned the revision 0 entry since
> > matches are registered in reverse order of appearance in the array
> > passed to xtables_register_matches(). The problem is that revision 0
> > doesn't define an xlate callback.
> >
> > Fix this by reordering the matches in conntrack_mt_reg so that the
> > highest revision one is found first.
>
> Applied, thanks Phil.
Wait.
Do you mean this case?
# iptables-translate -I INPUT -m state --state NEW
nft insert rule ip filter INPUT ct state new counter
Hm, this works here.
next prev parent reply other threads:[~2017-03-07 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 15:35 [iptables PATCH] extensions: libxt_conntrack: Fix 'state' translation to nft Phil Sutter
2017-03-07 16:17 ` Pablo Neira Ayuso
2017-03-07 16:20 ` Pablo Neira Ayuso [this message]
2017-03-07 16:54 ` Phil Sutter
2017-03-07 19:31 ` Pablo Neira Ayuso
2017-03-07 20:07 ` Phil Sutter
2017-03-08 10:36 ` Pablo Neira Ayuso
2017-03-08 12:31 ` Phil Sutter
2017-03-08 13:38 ` Pablo Neira Ayuso
2017-03-08 14:03 ` Phil Sutter
2017-03-08 15:43 ` [iptables PATCH] xtables-translate: Avoid querying the kernel Phil Sutter
2017-03-08 15:45 ` Pablo Neira Ayuso
2017-03-08 14:02 ` [iptables PATCH] extensions: libxt_conntrack: Fix 'state' translation to nft Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307162055.GA4753@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.