From: Andrea Ghittino <aghittino@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, david.kershner@unisys.com,
gregkh@linuxfoundation.org, sparmaintainer@unisys.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: unisys: fix sparse warnings
Date: Tue, 7 Mar 2017 22:48:03 +0100 [thread overview]
Message-ID: <20170307214802.GA4199@myhd3> (raw)
In-Reply-To: <20170307201736.GA11171@mwanda>
On Tue, Mar 07, 2017 at 11:17:36PM +0300, Dan Carpenter wrote:
> On Sat, Mar 04, 2017 at 06:20:50PM +0100, Andrea Ghittino wrote:
> > Sparse generates two warnings related to incorrect type in assignment.
> > This patch changes the types in the struct defined in unisys
>
> Can you post the Sparse warning? Otherwise when I'm reviewing this
> code I have to re-run Sparse to see what you're talking about.
>
> regards,
> dan carpenter
Here you can find sparse warnings:
drivers/staging/unisys/visornic/visornic_main.c:844:50: warning: incorrect type in assignment (different base types)
drivers/staging/unisys/visornic/visornic_main.c:844:50: expected unsigned short [unsigned] [usertype] protocol
drivers/staging/unisys/visornic/visornic_main.c:844:50: got restricted __be16 [usertype] protocol
drivers/staging/unisys/visornic/visornic_main.c:855:46: warning: incorrect type in assignment (different base types)
drivers/staging/unisys/visornic/visornic_main.c:855:46: expected unsigned int [unsigned] [usertype] csum
drivers/staging/unisys/visornic/visornic_main.c:855:46: got restricted __wsum [usertype] csum
andrea
prev parent reply other threads:[~2017-03-07 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 17:20 [PATCH] staging: unisys: fix sparse warnings Andrea Ghittino
2017-03-07 12:45 ` Kershner, David A
2017-03-07 20:17 ` Dan Carpenter
2017-03-07 21:48 ` Andrea Ghittino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307214802.GA4199@myhd3 \
--to=aghittino@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.