All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH stable v4.8] KVM: PPC: Book3S: Treat VTB as a per-subcore register, not per-thread
Date: Wed, 8 Mar 2017 06:01:58 +0100	[thread overview]
Message-ID: <20170308050158.GA3769@kroah.com> (raw)
In-Reply-To: <20170308004132.GC14927@fergus.ozlabs.ibm.com>

On Wed, Mar 08, 2017 at 11:41:32AM +1100, Paul Mackerras wrote:
> commit 88b02cf97bb7e742db3e31671d54177e3e19fd89 upstream.
> 
> POWER8 has one virtual timebase (VTB) register per subcore, not one
> per CPU thread.  The HV KVM code currently treats VTB as a per-thread
> register, which can lead to spurious soft lockup messages from guests
> which use the VTB as the time source for the soft lockup detector.
> (CPUs before POWER8 did not have the VTB register.)
> 
> For HV KVM, this fixes the problem by making only the primary thread
> in each virtual core save and restore the VTB value.  With this,
> the VTB state becomes part of the kvmppc_vcore structure.  This
> also means that "piggybacking" of multiple virtual cores onto one
> subcore is not possible on POWER8, because then the virtual cores
> would share a single VTB register.
> 
> PR KVM emulates a VTB register, which is per-vcpu because PR KVM
> has no notion of CPU threads or SMT.  For PR KVM we move the VTB
> state into the kvmppc_vcpu_book3s struct.
> 
> Cc: stable@vger.kernel.org # v3.14+
> Reported-by: Thomas Huth <thuth@redhat.com>
> Tested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
> ---
> This is intended for the 4.8 stable tree.

4.8 is long gone and not being maintained anymore, so there's not much
we can do with this, sorry.  Was there a specific distro that you were
concerned about not picking this up?

thanks,

greg k-h

      reply	other threads:[~2017-03-08 10:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  0:41 [PATCH stable v4.8] KVM: PPC: Book3S: Treat VTB as a per-subcore register, not per-thread Paul Mackerras
2017-03-08  5:01 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170308050158.GA3769@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=paulus@ozlabs.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.