From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: john.mcnamara@intel.com, dev@dpdk.org
Subject: Re: [PATCH v2] doc: fix parameter of virtio_user for container
Date: Wed, 8 Mar 2017 13:09:13 +0800 [thread overview]
Message-ID: <20170308050913.GA18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1488950271-28524-1-git-send-email-wang.yong19@zte.com.cn>
On Wed, Mar 08, 2017 at 12:17:51AM -0500, Yong Wang wrote:
> Update the "Virtio_user for Container Networking" doc, add the
> "--file-prefix" option to testpmd in host and container to avoid
> hugepage config file conflict.
>
> Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container networking")
>
> ---
The three-dashes denotes the end of the commit log. Anything below it
(including your Signed-off-by) will be discarded while apply. That said,
you should put the change log under the "---" after your SoB.
Besides, if someone gave you Acked-by, Reviewed-by or Tested-by and
you were requested to make some minor changes, you could carry the
tag for later versions. Which means, you could (and should) add both
my and John's Acked-by after your SoB for v3.
--yliu
> v2:
> * Modify the fixline from two lines to one line.
> * Remove the unnecessary "_" in "--file-prefix" option.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
> doc/guides/howto/virtio_user_for_container_networking.rst | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
prev parent reply other threads:[~2017-03-08 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 5:17 [PATCH v2] doc: fix parameter of virtio_user for container Yong Wang
2017-03-08 5:09 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308050913.GA18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=wang.yong19@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.