From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 08/10] drm/i915: Split cursor check_plane into i845 and i9xx variants Date: Wed, 8 Mar 2017 12:52:23 +0200 Message-ID: <20170308105223.GC31595@intel.com> References: <20170307152709.31957-1-ville.syrjala@linux.intel.com> <20170307152709.31957-9-ville.syrjala@linux.intel.com> <20170307222421.GA25491@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B9E06E021 for ; Wed, 8 Mar 2017 10:52:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170307222421.GA25491@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDcsIDIwMTcgYXQgMTA6MjQ6MjFQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFR1ZSwgTWFyIDA3LCAyMDE3IGF0IDA1OjI3OjA3UE0gKzAyMDAsIHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gVGhlIDg0NS84NjUgYW5kIDgz MC84NTUvOXh4KyBzdHlsZSBjdXJzb3IgZG9uJ3QgaGF2ZSB0aGF0Cj4gPiBtdWNoIGluIGNvbW1v biB3aXRoIGVhY2ggb3RoZXIsIHNvIGxldCdzIGp1c3Qgc3BsaXQgdGhlCj4gPiAuY2hlY2tfcGxh bmUoKSBob29rIGludG8gdHdvIHZhcmlhbnRzIGFzIHdlbGwuCj4gPiAKPiA+IFNpZ25lZC1vZmYt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAt LS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyMzIgKysrKysr KysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTQ1IGlu c2VydGlvbnMoKyksIDg3IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gPiBpbmRleCAyMjJmNTRmZmQxMTMuLjQxY2JhZWU2NmYxYiAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtOTI2OSw2ICs5MjY5 LDc0IEBAIHN0YXRpYyB2b2lkIGk4NDVfZGlzYWJsZV9jdXJzb3Ioc3RydWN0IGludGVsX3BsYW5l ICpwbGFuZSwKPiA+ICAJaTg0NV91cGRhdGVfY3Vyc29yKHBsYW5lLCBOVUxMLCBOVUxMKTsKPiA+ ICB9Cj4gPiAgCj4gPiArc3RhdGljIGJvb2wgaTg0NV9jdXJzb3Jfc2l6ZV9vayhjb25zdCBzdHJ1 Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ID4gK3sKPiA+ICsJc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0KPiA+ICsJCXRvX2k5MTUocGxhbmVfc3RhdGUtPmJh c2UucGxhbmUtPmRldik7Cj4gPiArCWludCB3aWR0aCA9IHBsYW5lX3N0YXRlLT5iYXNlLmNydGNf dzsKPiA+ICsJaW50IGhlaWdodCA9IHBsYW5lX3N0YXRlLT5iYXNlLmNydGNfaDsKPiA+ICsKPiA+ ICsJaWYgKHdpZHRoID09IDAgfHwgaGVpZ2h0ID09IDApCj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4g PiArCj4gPiArCS8qCj4gPiArCSAqIDg0NWcvODY1ZyBhcmUgb25seSBsaW1pdGVkIGJ5IHRoZSB3 aWR0aCBvZiB0aGVpciBjdXJzb3JzLAo+ID4gKwkgKiB0aGUgaGVpZ2h0IGlzIGFyYml0cmFyeSB1 cCB0byB0aGUgcHJlY2lzaW9uIG9mIHRoZSByZWdpc3Rlci4KPiA+ICsJICovCj4gPiArCWlmICgo d2lkdGggJiA2MykgIT0gMCkKPiAKPiBpZiAoIUlTX0FMSUdORUQod2lkdGgsIDY0KSkgPwoKV2h5 IG5vdC4KCj4gCj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiArCj4gPiArCWlmICh3aWR0aCA+IChJ U19JODQ1RyhkZXZfcHJpdikgPyA2NCA6IDUxMikpCj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiAr Cj4gPiArCWlmIChoZWlnaHQgPiAxMDIzKQo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gKwo+ID4g KwlyZXR1cm4gdHJ1ZTsKPiA+ICt9Cj4gCj4gPiAgc3RhdGljIHZvaWQgaTl4eF91cGRhdGVfY3Vy c29yKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gPiAgCQkJICAgICAgIGNvbnN0IHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ID4gIAkJCSAgICAgICBjb25zdCBzdHJ1 Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ID4gQEAgLTkzMjgsNDEgKzkzOTYs OTIgQEAgc3RhdGljIHZvaWQgaTl4eF9kaXNhYmxlX2N1cnNvcihzdHJ1Y3QgaW50ZWxfcGxhbmUg KnBsYW5lLAo+ID4gIAlpOXh4X3VwZGF0ZV9jdXJzb3IocGxhbmUsIE5VTEwsIE5VTEwpOwo+ID4g IH0KPiA+ICAKPiA+IC1zdGF0aWMgYm9vbCBjdXJzb3Jfc2l6ZV9vayhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAtCQkJICAgdWludDMyX3Qgd2lkdGgsIHVpbnQzMl90IGhl aWdodCkKPiA+ICtzdGF0aWMgYm9vbCBpOXh4X2N1cnNvcl9zaXplX29rKGNvbnN0IHN0cnVjdCBp bnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gPiAgewo+ID4gKwlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPQo+ID4gKwkJdG9faTkxNShwbGFuZV9zdGF0ZS0+YmFzZS5w bGFuZS0+ZGV2KTsKPiA+ICsJaW50IHdpZHRoID0gcGxhbmVfc3RhdGUtPmJhc2UuY3J0Y193Owo+ ID4gKwlpbnQgaGVpZ2h0ID0gcGxhbmVfc3RhdGUtPmJhc2UuY3J0Y19oOwo+ID4gKwo+ID4gIAlp ZiAod2lkdGggPT0gMCB8fCBoZWlnaHQgPT0gMCkKPiA+ICAJCXJldHVybiBmYWxzZTsKPiA+ICAK PiA+ICAJLyoKPiA+IC0JICogODQ1Zy84NjVnIGFyZSBzcGVjaWFsIGluIHRoYXQgdGhleSBhcmUg b25seSBsaW1pdGVkIGJ5Cj4gPiAtCSAqIHRoZSB3aWR0aCBvZiB0aGVpciBjdXJzb3JzLCB0aGUg aGVpZ2h0IGlzIGFyYml0cmFyeSB1cCB0bwo+ID4gLQkgKiB0aGUgcHJlY2lzaW9uIG9mIHRoZSBy ZWdpc3Rlci4gRXZlcnl0aGluZyBlbHNlIHJlcXVpcmVzCj4gPiAtCSAqIHNxdWFyZSBjdXJzb3Jz LCBsaW1pdGVkIHRvIGEgZmV3IHBvd2VyLW9mLXR3byBzaXplcy4KPiA+ICsJICogQ3Vyc29ycyBh cmUgbGltaXRlZCB0byBhIGZldyBwb3dlci1vZi10d28KPiA+ICsJICogc2l6ZXMsIGFuZCB0aGV5 IG11c3QgYmUgc3F1YXJlLgo+ID4gIAkgKi8KPiA+IC0JaWYgKElTX0k4NDVHKGRldl9wcml2KSB8 fCBJU19JODY1RyhkZXZfcHJpdikpIHsKPiA+IC0JCWlmICgod2lkdGggJiA2MykgIT0gMCkKPiA+ ICsJc3dpdGNoICh3aWR0aCB8IGhlaWdodCkgewo+ID4gKwljYXNlIDI1NjoKPiA+ICsJY2FzZSAx Mjg6Cj4gPiArCQlpZiAoSVNfR0VOMihkZXZfcHJpdikpCj4gPiAgCQkJcmV0dXJuIGZhbHNlOwo+ ID4gKwljYXNlIDY0Ogo+ID4gKwkJYnJlYWs7Cj4gPiArCWRlZmF1bHQ6Cj4gPiArCQlyZXR1cm4g ZmFsc2U7Cj4gCj4gQ2hlY2tzIG91dCBvay4KPiAKPiA+ICsJfQo+IAo+IFRoZXJlJ3Mgc3RpbGwg cXVpdGUgYSBiaXQgb2YgYm9pbGVycGxhdGUgZHVwbGljYXRpb24gYmV0d2VlbiB0aGUgdHdvCj4g Y2hlY2tfcGxhbmUgZnVuY3Rpb25zLiBObyBjaGFuY2UgZm9yIHNvbWUgc2hhcmluZz8gSSBwcmVz dW1lIHRoZWlyIGlzCj4gYWxzbyBhbiB1bHRlcmlvciBtb3RpdmUgZm9yIHRoZSBzcGxpdCBpbiBs YXRlciBwYXRjaGVzLiBUaGF0IHdvdWxkIGJlCj4gd29ydGggbWVudGlvbmluZyBpbiB0aGUgY2hh bmdlbG9nIHRvIHF1ZWxsIHNvbWUgb2YgdGhlIGRvdWJ0cyBvdmVyCj4gZHVwbGljYXRpb24uCgpJ IHRoaW5rIGluIHRoZSBlbmQgd2UncmUgbGVmdCB3aXRoIHRoZSBkcm1fcGxhbmVfaGVscGVyX2No ZWNrX3N0YXRlKCkKY2FsbCBhbmQgdGhlIG1vZGlmaWVyIGNoZWNrLiBUaG9zZSBjb3VsZCBiZSBk b25lIGJhY2sgdG8gYmFjayBhbmQgbW92ZWQKdG8gYSBjb21tb24gcGxhY2UuIEFsdGhvdWdoIEkn bSBzb3J0IG9mIGhvcGluZyB0aGUgbW9kaWZpZXIgY2hlY2sgY2FuCmJlIG1hZGUgdG8gdmFuaXNo IG9uY2Ugd2UgZ2V0IHRoZSBnZXRwbGFuZTIgc3R1ZmYgYW5kIHRoZSBkcml2ZXIgcHJvdmlkZXMK dGhlIGNvcmUgd2l0aCBhbiBleHBsaWNpdCBsaXN0IG9mIGFjY2VwdGFibGUgbW9kaWZpZXJzIGZv ciBlYWNoIHBsYW5lLgpTbyB3ZSBtaWdodCBiZSBsZWZ0IHdpdGgganVzdCB0aGUgY2hlY2tfc3Rh dGUoKSBjYWxsLgoKT1RPSCB3ZSdyZSBhY3R1YWxseSBtaXNzaW5nIGFueSBhbmQgYWxsIGNoZWNr cyBmb3IgdGhlIHNyYyBjb29yZGluYXRlcy4KVGhlIGN1cnNvciBwbGFuZSBjYW4ndCBwYW4gYXJv dW5kIGZyZWVseSwgc28gd2Ugc2hvdWxkIGFkZCBzb21lIGNoZWNrcwpmb3IgdGhhdCwgYW5kIHB1 dHRpbmcgdGhvc2UgaW50byBhIGNvbW1vbiBwbGFjZSBtaWd0aCBiZSB0aGUgcmlnaHQKdGhpbmcu IEknbSBub3Qgc3VyZSBpZiB3ZSBzaG91bGQganVzdCBzYXkgeW91IGNhbid0IHBhbiBhdCBhbGws IG9yCnRoYXQgdGhlIHBhbm5pbmcgbXVzdCBoYXBwZW4gaW4gd2hhdGV2ZXIgY2h1bmtzIENVUkJB U0UgYWxsb3dzLgpPYnZpb3VzbHkgb24gbW9zdCBwbGF0Zm9ybXMgdGhhdCB3b3VsZCBzdGlsbCBv bmx5IGFsbG93IHZlcnRpY2FsCnBhbm5pbmcgaW4gdW5pdHMgb2Ygc2V2ZXJhbCBsaW5lcy4gU2hv dWxkIGJlIHByZXR0eSB0cml2aWFsIHRvIGFjaGlldmUKdGhhdCB3aXRoIGEgY2FsbCB0byB0aGUg Y29tcHV0ZV90aWxlX29mZnNldCgpIHRoaW5nIGFuZCBhIGNoZWNrIHRvIG1ha2UKc3VyZSB0aGUg bGVmdG92ZXIgeC95IGNvb3JkaW5hdGVzIGFyZSAwLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl bCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==