From: Tuomas Tynkkynen <tuomas@tuxera.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>,
Eric Van Hensbergen <ericvh@gmail.com>,
<v9fs-developer@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] fs/9p: Compare qid.path in v9fs_test_inode
Date: Wed, 8 Mar 2017 15:46:10 +0200 [thread overview]
Message-ID: <20170308154610.59a563a3@duuni> (raw)
In-Reply-To: <20170222000629.7995-1-tuomas@tuxera.com>
On Wed, 22 Feb 2017 02:06:29 +0200
Tuomas Tynkkynen <tuomas@tuxera.com> wrote:
> Commit fd2421f54423 ("fs/9p: When doing inode lookup compare qid details
> and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked()
> instead of iget_locked(). However, the test() callback is not checking
> fid.path at all, which means that a lookup in the inode cache can now
> accidentally locate a completely wrong inode from the same inode hash
> bucket if the other fields (qid.type and qid.version) match.
>
Al, does this sound sensible? (or if there is someone else picking up 9p
patches, let me know).
Thanks!
- Tuomas
next prev parent reply other threads:[~2017-03-08 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 0:06 [PATCH] fs/9p: Compare qid.path in v9fs_test_inode Tuomas Tynkkynen
2017-03-08 13:46 ` Tuomas Tynkkynen [this message]
2017-03-09 17:26 ` Latchesar Ionkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308154610.59a563a3@duuni \
--to=tuomas@tuxera.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ericvh@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.