From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6395175324693299200 X-Received: by 10.200.33.233 with SMTP id 38mr1842071qtz.87.1489002674242; Wed, 08 Mar 2017 11:51:14 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.11.156 with SMTP id 28ls1210519iol.20.gmail; Wed, 08 Mar 2017 11:51:13 -0800 (PST) X-Received: by 10.99.114.70 with SMTP id c6mr3698401pgn.17.1489002673190; Wed, 08 Mar 2017 11:51:13 -0800 (PST) Return-Path: Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com. [2607:f8b0:400e:c05::243]) by gmr-mx.google.com with ESMTPS id g82si788025pfb.5.2017.03.08.11.51.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Mar 2017 11:51:13 -0800 (PST) Received-SPF: pass (google.com: domain of amsfield22@gmail.com designates 2607:f8b0:400e:c05::243 as permitted sender) client-ip=2607:f8b0:400e:c05::243; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com; spf=pass (google.com: domain of amsfield22@gmail.com designates 2607:f8b0:400e:c05::243 as permitted sender) smtp.mailfrom=amsfield22@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-pg0-x243.google.com with SMTP id 25so4327209pgy.3 for ; Wed, 08 Mar 2017 11:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=j56H9FQJ5/yL21MLMN2jH0mQJUEbzCunM+RGpRhZEdA=; b=aI3zL3N6Ri9x9l4q9pHWDs1o8lSZaCZ9CwmDo92ukTaM0WIQQmaDr6KdRyqbg5szZj ldqUJfBZbg8jOcQBUSuMiwcy2gkFNrDaLNKF9dL1C5iC/O2+n4JoZva5gpnO5v/iuSdo gTd+U0wjVUF6YS1oMcM9W3UAXA/ip3qKz9R9atNCbvoT7PAU2gHg+mvhVTYvo8ZI5YF6 PkK3OzVqRQdPxUBPCVj2fQ2SAT92+AIPu/3dLAo81PeXGBUZbEd4iCP7MP9h/Dg1VOi9 Nj9WHvDQtRIEBbkw+phqobfe3zCfNc7HOi4kdnica2mqrp0Vyz9PmUdQRusAJiUzwJ5u 1MlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j56H9FQJ5/yL21MLMN2jH0mQJUEbzCunM+RGpRhZEdA=; b=fMOb+xagQCe1hTpQ5o3WfKYnzdcJf+jipIuoCLgIwVk4YhDV5rwnUA9oR1egIqDpq7 36BgZY65QWNoSFTNaVthbYjfvo/ZM+8tP0yMOnWkN47liXyRMFDTu+VPHLqp5vA1ZOWu Zf1c6C9y8t0/1WA77gs+cnHXtUaMvQf9xbKh8Fiqo3OkkQRsqBmTeCAzlOLU//WEIJyI MMn440cTq6zqzv6MSDIKSwwMRG9YkgAZ6euF6oiZSva49BTMc7KTa0cDigs67dLWKX0d qopcmbAIjLvtcqAvd6gajuhRNRpDuQdPk1MAxlXmqEv/JHxZADq+3uNeXQtjMa+3mHkT BmBA== X-Gm-Message-State: AMke39l5O9pZomukTcHf7+8dOTnqB3RGKsjBB6GHibS4pUJYvJ75IA1uFklPcBCdsg5igg== X-Received: by 10.98.192.25 with SMTP id x25mr9386544pff.158.1489002672808; Wed, 08 Mar 2017 11:51:12 -0800 (PST) Return-Path: Received: from d830 (or-67-232-66-135.dhcp.embarqhsd.net. [67.232.66.135]) by smtp.gmail.com with ESMTPSA id e70sm7718748pfl.105.2017.03.08.11.51.11 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Mar 2017 11:51:12 -0800 (PST) Date: Wed, 8 Mar 2017 11:51:11 -0800 From: Alison Schofield To: Tamara Diaconita Cc: aditya.shankar@microchip.com, ganesh.krishna@microchip.com, gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com, Tamara Diaconita Subject: Re: [Outreachy kernel] [PATCH 1/3] staging: wilc1000: wilc_spi: Rearrange the code Message-ID: <20170308195109.GA3284@d830.WORKGROUP> References: <20170308170620.3898-1-diaconita.tamara@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170308170620.3898-1-diaconita.tamara@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) On Wed, Mar 08, 2017 at 07:06:20PM +0200, Tamara Diaconita wrote: > Split lines to have less than 80 characters. > > Fix the checkpath.pl issue: line over 80 characters. > > Signed-off-by: Tamara Diaconita Hi Tamara, You certainly found a file with a lot of opportunity for cleanup! This patch didn't apply, and I didn't seen any recent submittals that would have pre-dated your work. I got this error message when trying to apply it: Applying: staging: wilc1000: wilc_spi: Rearrange the code error: patch failed: drivers/staging/wilc1000/wilc_spi.c:855 error: drivers/staging/wilc1000/wilc_spi.c: patch does not apply Patch failed at 0001 staging: wilc1000: wilc_spi: Rearrange the code It could be 'my' problem ;), but since I'm going to ask you to rework this anyway, please apply the patch and see what is going on there. Lines over 80 can be tricky to fix. I see many related to comments, so I would suggest to do a patch just for cleaning up the commenting style and spelling errors. The patch would be something like: Use kernel preferred commenting style and it could include corrections to - those block comments throughout the file. See the style guide for how they should be formatted. - spelling corrections - pulling in those comments that dangle beyond the 80 char line limit So - that would be a patch all about the comments. Then, you could go back and grab other lines over 80 that were related to code wrap in a separate patch. Questions, please ask! Thanks, alisons > --- > drivers/staging/wilc1000/wilc_spi.c | 54 ++++++++++++++++++++++--------------- > 1 file changed, 32 insertions(+), 22 deletions(-) > > diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c > index 5e28adc..2464b4c 100644 > --- a/drivers/staging/wilc1000/wilc_spi.c > +++ b/drivers/staging/wilc1000/wilc_spi.c > @@ -5,7 +5,7 @@ > /* Module Name: wilc_spi.c */ > /* */ > /* */ > -/* //////////////////////////////////////////////////////////////////////////// */ > +/* ///////////////////////////////////////////////////////////////////////// */ > #include > #include > #include > @@ -291,7 +291,7 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz, > > wb[0] = cmd; > switch (cmd) { > - case CMD_SINGLE_READ: /* single word (4 bytes) read */ > + case CMD_SINGLE_READ: /* single word (4 bytes) read */ > wb[1] = (u8)(adr >> 16); > wb[2] = (u8)(adr >> 8); > wb[3] = (u8)adr; > @@ -307,21 +307,21 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz, > len = 5; > break; > > - case CMD_TERMINATE: /* termination */ > + case CMD_TERMINATE: /* termination */ > wb[1] = 0x00; > wb[2] = 0x00; > wb[3] = 0x00; > len = 5; > break; > > - case CMD_REPEAT: /* repeat */ > + case CMD_REPEAT: /* repeat */ > wb[1] = 0x00; > wb[2] = 0x00; > wb[3] = 0x00; > len = 5; > break; > > - case CMD_RESET: /* reset */ > + case CMD_RESET: /* reset */ > wb[1] = 0xff; > wb[2] = 0xff; > wb[3] = 0xff; > @@ -397,11 +397,12 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz, > len2 = len + (NUM_SKIP_BYTES + NUM_RSP_BYTES + NUM_DUMMY_BYTES); > } else if ((cmd == CMD_INTERNAL_READ) || (cmd == CMD_SINGLE_READ)) { > if (!g_spi.crc_off) { > - len2 = len + (NUM_RSP_BYTES + NUM_DATA_HDR_BYTES + NUM_DATA_BYTES > - + NUM_CRC_BYTES + NUM_DUMMY_BYTES); > + len2 = len + (NUM_RSP_BYTES + NUM_DATA_HDR_BYTES + > + NUM_DATA_BYTES + NUM_CRC_BYTES + > + NUM_DUMMY_BYTES); > } else { > - len2 = len + (NUM_RSP_BYTES + NUM_DATA_HDR_BYTES + NUM_DATA_BYTES > - + NUM_DUMMY_BYTES); > + len2 = len + (NUM_RSP_BYTES + NUM_DATA_HDR_BYTES + > + NUM_DATA_BYTES + NUM_DUMMY_BYTES); > } > } else { > len2 = len + (NUM_RSP_BYTES + NUM_DUMMY_BYTES); > @@ -464,7 +465,8 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz, > **/ > retry = 100; > do { > - /* ensure there is room in buffer later to read data and crc */ > + /* ensure there is room in buffer later to read data > + * and crc */ > if (rix < len2) { > rsp = rb[rix++]; > } else { > @@ -549,7 +551,8 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz, > sz -= nbytes; > } > > - /* if any data in left unread, then read the rest using normal DMA code.*/ > + /* if any data in left unread, then read the rest > + * using normal DMA code.*/ > while (sz > 0) { > int nbytes; > > @@ -559,9 +562,10 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz, > nbytes = DATA_PKT_SZ; > > /** > - * read data response only on the next DMA cycles not > - * the first DMA since data response header is already > - * handled above for the first DMA. > + * read data response only on the next DMA > + * cycles not the first DMA since data response > + * header is already handled above for the > + * first DMA. > **/ > /** > * Data Respnose header > @@ -569,7 +573,8 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz, > retry = 10; > do { > if (wilc_spi_rx(wilc, &rsp, 1)) { > - dev_err(&spi->dev, "Failed data response read, bus error...\n"); > + dev_err(&spi->dev, > + "Failed data response read, bus error...\n"); > result = N_FAIL; > break; > } > @@ -855,16 +860,18 @@ static int wilc_spi_init(struct wilc *wilc, bool resume) > **/ > g_spi.crc_off = 0; > > - /* TODO: We can remove the CRC trials if there is a definite way to reset */ > - /* the SPI to it's initial value. */ > + /* TODO: We can remove the CRC trials if there is a definite way to > + * reset the SPI to it's initial value. */ > if (!spi_internal_read(wilc, WILC_SPI_PROTOCOL_OFFSET, ®)) { > /* Read failed. Try with CRC off. This might happen when module > * is removed but chip isn't reset > */ > g_spi.crc_off = 1; > - dev_err(&spi->dev, "Failed internal read protocol with CRC on, retrying with CRC off...\n"); > + dev_err(&spi->dev, "Failed internal read protocol with CRC on, > + retrying with CRC off...\n"); > if (!spi_internal_read(wilc, WILC_SPI_PROTOCOL_OFFSET, ®)) { > - /* Reaad failed with both CRC on and off, something went bad */ > + /* Reaad failed with both CRC on and off, something > + * went bad */ > dev_err(&spi->dev, > "Failed internal read protocol...\n"); > return 0; > @@ -875,7 +882,8 @@ static int wilc_spi_init(struct wilc *wilc, bool resume) > reg &= ~0x70; > reg |= (0x5 << 4); > if (!spi_internal_write(wilc, WILC_SPI_PROTOCOL_OFFSET, reg)) { > - dev_err(&spi->dev, "[wilc spi %d]: Failed internal write protocol reg...\n", __LINE__); > + dev_err(&spi->dev, "[wilc spi %d]: Failed internal > + write protocol reg...\n", __LINE__); > return 0; > } > g_spi.crc_off = 1; > @@ -1002,9 +1010,11 @@ static int wilc_spi_clear_int_ext(struct wilc *wilc, u32 val) > > ret = 1; > for (i = 0; i < g_spi.nint; i++) { > - /* No matter what you write 1 or 0, it will clear interrupt. */ > + /* No matter what you write 1 or 0, it will > + * clear interrupt. */ > if (flags & 1) > - ret = wilc_spi_write_reg(wilc, 0x10c8 + i * 4, 1); > + ret = wilc_spi_write_reg(wilc, 0x10c8 + > + i * 4, 1); > if (!ret) > break; > flags >>= 1; > -- > 2.9.3 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170308170620.3898-1-diaconita.tamara%40gmail.com. > For more options, visit https://groups.google.com/d/optout.