Re: [Outreachy kernel] [PATCH 3/3] staging: wilc1000: wilc_spi: Add blank line

[Alison Schofield <amsfield22@gmail.com>]

On Wed, Mar 08, 2017 at 07:06:52PM +0200, Tamara Diaconita wrote:
> Add a blank line after a function.
> 
> Fix the checkpath.pl issue:
               ^^^^checkpatch

Hi Tamara, 

This one looks good, but since you're going to rev the
patchset for the others, I'm going to be picky and ask you to
update this for the checkpatch spelling and for the subject line.

I did a gitpretty (alias gitpretty='git log --pretty=oneline
--abbrev-commit') to see what is customary for this file.
Just the driver name is customary.  I see that one submitter
before you, added the filename also, but let's not continue
that trend ;)

Dropping the .c filename from the subject line applies to 
all patches in the set.

Thanks,
alisons






> CHECK: Please use a blank line after function/struct/union.
> 
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
> ---
>  drivers/staging/wilc1000/wilc_spi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
> index 4a4b8c3..82d162d 100644
> --- a/drivers/staging/wilc1000/wilc_spi.c
> +++ b/drivers/staging/wilc1000/wilc_spi.c
> @@ -1146,6 +1146,7 @@ static int wilc_spi_sync_ext(struct wilc *wilc, int nint)
>  
>  	return 1;
>  }
> +
>  /********************************************
>   *
>   *      Global spi HIF function table
> -- 
> 2.9.3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170308170652.3996-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.