From: "hch-jcswGhMUV9g@public.gmane.org" <hch-jcswGhMUV9g@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org"
<sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
"hch-jcswGhMUV9g@public.gmane.org"
<hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH] IB/cq: Don't process more than the given budget
Date: Wed, 8 Mar 2017 23:12:27 +0100 [thread overview]
Message-ID: <20170308221227.GA447@lst.de> (raw)
In-Reply-To: <1489010916.2813.4.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On Wed, Mar 08, 2017 at 10:09:08PM +0000, Bart Van Assche wrote:
> > - while ((n = ib_poll_cq(cq, IB_POLL_BATCH, cq->wc)) > 0) {
> > + while ((n = ib_poll_cq(cq, min(IB_POLL_BATCH, budget - completed),
> > + cq->wc)) > 0) {
> > for (i = 0; i < n; i++) {
> > struct ib_wc *wc = &cq->wc[i];
> >
>
> This breaks the SRP initiator driver since that driver can pass -1 as budget.
Good point, we'd need to special case that.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-08 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 20:10 [PATCH] IB/cq: Don't process more than the given budget Sagi Grimberg
[not found] ` <1489003801-4410-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-03-08 21:36 ` Christoph Hellwig
2017-03-08 22:09 ` Bart Van Assche
[not found] ` <1489010916.2813.4.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-08 22:12 ` hch-jcswGhMUV9g [this message]
[not found] ` <20170308221227.GA447-jcswGhMUV9g@public.gmane.org>
2017-03-08 22:14 ` Bart Van Assche
[not found] ` <1489011263.2813.9.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-08 22:59 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308221227.GA447@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.