From: Alison Schofield <amsfield22@gmail.com>
To: Tamara Diaconita <diaconitatamara@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com,
Tamara Diaconita <diaconita.tamara@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH] staging: ks7010: eap_packet: Format comments to fit in line
Date: Wed, 8 Mar 2017 16:58:10 -0800 [thread overview]
Message-ID: <20170309005809.GA21318@d830.WORKGROUP> (raw)
In-Reply-To: <20170308223650.3791-1-diaconita.tamara@gmail.com>
On Thu, Mar 09, 2017 at 12:36:50AM +0200, Tamara Diaconita wrote:
> Split lines to have less than 80 characters.
>
> Fix the checkpatch.pl warning:
> WARNING: line over 80 characters.
>
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
Hi Tamara,
This one will need to be labelled as [PATCH v2].
So - send it again and label it as such. Remember to include what
changed in v2 below the --- line.
Thanks,
alisons
> ---
> drivers/staging/ks7010/eap_packet.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
> index df7f760..7a3decf 100644
> --- a/drivers/staging/ks7010/eap_packet.h
> +++ b/drivers/staging/ks7010/eap_packet.h
> @@ -58,12 +58,15 @@ struct ieee802_1x_eapol_key {
> * encrypt the Key field; 64-bit NTP timestamp MAY be used here
> */
> unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
> - unsigned char key_iv[IEEE8021X_KEY_IV_LEN]; /* cryptographically random number */
> + unsigned char key_iv[IEEE8021X_KEY_IV_LEN]; /* cryptographically random
> + * number
> + */
> unsigned char key_index; /*
> * key flag in the most significant bit:
> * 0 = broadcast (default key),
> - * 1 = unicast (key mapping key); key index is in the
> - * 7 least significant bits
> + * 1 = unicast (key mapping key);
> + * key index is in the 7 least
> + * significant bits
> */
> /*
> * HMAC-MD5 message integrity check computed with MS-MPPE-Send-Key as
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170308223650.3791-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2017-03-09 0:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 22:36 [PATCH] staging: ks7010: eap_packet: Format comments to fit in line Tamara Diaconita
2017-03-09 0:58 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309005809.GA21318@d830.WORKGROUP \
--to=amsfield22@gmail.com \
--cc=diaconita.tamara@gmail.com \
--cc=diaconitatamara@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.