From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH] net/mlx5: fix TSO TCP checksum flag Date: Thu, 9 Mar 2017 08:17:56 +0100 Message-ID: <20170309071756.GQ22756@autoinstall.dev.6wind.com> References: <1488887271-34342-1-git-send-email-shahafs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org To: Shahaf Shuler Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 533D3D018 for ; Thu, 9 Mar 2017 08:18:05 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id t189so48453993wmt.1 for ; Wed, 08 Mar 2017 23:18:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <1488887271-34342-1-git-send-email-shahafs@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 07, 2017 at 01:47:51PM +0200, Shahaf Shuler wrote: > Since PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM, the PMD must force this > flag. > The fix applied for both tunneled and non-tunneled packets. > > Fixes: 19c5dc66b851 ("net/mlx5: add hardware TSO support") > Fixes: 751f56489e31 ("net/mlx5: add hardware TSO support for VXLAN and GRE") > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5_rxtx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 405836c..2d33f2d 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -499,6 +499,9 @@ > if (is_tunneled && txq->tunnel_en) { > tso_header_sz += buf->outer_l2_len + > buf->outer_l3_len; > + cs_flags |= MLX5_ETH_WQE_L4_INNER_CSUM; > + } else { > + cs_flags |= MLX5_ETH_WQE_L4_CSUM; > } > if (unlikely(tso_header_sz > > MLX5_MAX_TSO_HEADER)) > -- > 1.8.3.1 > Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND