diff for duplicates of <20170309114339.GD3307@yuval-lap> diff --git a/a/1.txt b/N1/1.txt index 891c083..658bd3f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -31,7 +31,7 @@ Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > > struct ocrdma_mm *mm; > > > > mm = kzalloc(sizeof(*mm), GFP_KERNEL); -> > - if (mm = NULL) +> > - if (mm == NULL) > > + if (!mm) > > return -ENOMEM; > > mm->key.phy_addr = phy_addr; @@ -40,7 +40,7 @@ Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > > { > > int status = -EINVAL; > > -> > - if (qp->id < OCRDMA_MAX_QP && dev->qp_tbl[qp->id] = NULL) { +> > - if (qp->id < OCRDMA_MAX_QP && dev->qp_tbl[qp->id] == NULL) { > > + if (qp->id < OCRDMA_MAX_QP && !dev->qp_tbl[qp->id]) { > > dev->qp_tbl[qp->id] = qp; > > status = 0; @@ -49,12 +49,12 @@ Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > > { > > qp->wqe_wr_id_tbl = kcalloc(qp->sq.max_cnt, sizeof(*qp->wqe_wr_id_tbl), > > GFP_KERNEL); -> > - if (qp->wqe_wr_id_tbl = NULL) +> > - if (qp->wqe_wr_id_tbl == NULL) > > + if (!qp->wqe_wr_id_tbl) > > return -ENOMEM; > > qp->rqe_wr_id_tbl = kcalloc(qp->rq.max_cnt, sizeof(*qp->rqe_wr_id_tbl), > > GFP_KERNEL); -> > - if (qp->rqe_wr_id_tbl = NULL) +> > - if (qp->rqe_wr_id_tbl == NULL) > > + if (!qp->rqe_wr_id_tbl) > > return -ENOMEM; > > @@ -63,7 +63,7 @@ Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > > goto gen_err; > > } > > ocrdma_set_qp_init_params(qp, pd, attrs); -> > - if (udata = NULL) +> > - if (udata == NULL) > > + if (!udata) > > qp->cap_flags |= (OCRDMA_QP_MW_BIND | OCRDMA_QP_LKEY0 | > > OCRDMA_QP_FAST_REG); @@ -72,7 +72,7 @@ Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > > goto mbx_err; > > > > /* user space QP's wr_id table are managed in library */ -> > - if (udata = NULL) { +> > - if (udata == NULL) { > > + if (!udata) { > > status = ocrdma_alloc_wr_id_tbl(qp); > > if (status) @@ -81,12 +81,12 @@ Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > > if (status) > > goto err; > > -> > - if (udata = NULL) { +> > - if (udata == NULL) { > > + if (!udata) { > > srq->rqe_wr_id_tbl = kcalloc(srq->rq.max_cnt, > > sizeof(*srq->rqe_wr_id_tbl), > > GFP_KERNEL); -> > - if (srq->rqe_wr_id_tbl = NULL) +> > - if (srq->rqe_wr_id_tbl == NULL) > > + if (!srq->rqe_wr_id_tbl) > > goto arm_err; > > @@ -95,16 +95,16 @@ Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > > srq->idx_bit_fields = kmalloc_array(srq->bit_fields_len, > > sizeof(*srq->idx_bit_fields), > > GFP_KERNEL); -> > - if (srq->idx_bit_fields = NULL) +> > - if (srq->idx_bit_fields == NULL) > > + if (!srq->idx_bit_fields) > > goto arm_err; > > memset(srq->idx_bit_fields, 0xff, > > srq->bit_fields_len * sizeof(*srq->idx_bit_fields)); > > @@ -2878,7 +2878,7 @@ static int ocrdma_poll_hwcq(struct ocrdma_cq *cq, int num_entries, -> > if (qpn = 0) +> > if (qpn == 0) > > goto skip_cqe; > > qp = dev->qp_tbl[qpn]; -> > - BUG_ON(qp = NULL); +> > - BUG_ON(qp == NULL); > > + BUG_ON(!qp); > > > > expand = is_cqe_for_sq(cqe) diff --git a/a/content_digest b/N1/content_digest index cf239b7..31e83b6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0CANjDDBgGxuYvm9KL5MYHNVJuR+YDNQN=uDd1sHzLGggRTzyk3A@mail.gmail.com\0" "From\0Yuval Shaia <yuval.shaia@oracle.com>\0" "Subject\0Re: [PATCH 26/26] IB/ocrdma: Adjust further ten checks for null pointers\0" - "Date\0Thu, 09 Mar 2017 11:43:40 +0000\0" + "Date\0Thu, 9 Mar 2017 13:43:40 +0200\0" "To\0Devesh Sharma <devesh.sharma@broadcom.com>\0" "Cc\0SF Markus Elfring <elfring@users.sourceforge.net>" linux-rdma <linux-rdma@vger.kernel.org> @@ -49,7 +49,7 @@ "> > struct ocrdma_mm *mm;\n" "> >\n" "> > mm = kzalloc(sizeof(*mm), GFP_KERNEL);\n" - "> > - if (mm = NULL)\n" + "> > - if (mm == NULL)\n" "> > + if (!mm)\n" "> > return -ENOMEM;\n" "> > mm->key.phy_addr = phy_addr;\n" @@ -58,7 +58,7 @@ "> > {\n" "> > int status = -EINVAL;\n" "> >\n" - "> > - if (qp->id < OCRDMA_MAX_QP && dev->qp_tbl[qp->id] = NULL) {\n" + "> > - if (qp->id < OCRDMA_MAX_QP && dev->qp_tbl[qp->id] == NULL) {\n" "> > + if (qp->id < OCRDMA_MAX_QP && !dev->qp_tbl[qp->id]) {\n" "> > dev->qp_tbl[qp->id] = qp;\n" "> > status = 0;\n" @@ -67,12 +67,12 @@ "> > {\n" "> > qp->wqe_wr_id_tbl = kcalloc(qp->sq.max_cnt, sizeof(*qp->wqe_wr_id_tbl),\n" "> > GFP_KERNEL);\n" - "> > - if (qp->wqe_wr_id_tbl = NULL)\n" + "> > - if (qp->wqe_wr_id_tbl == NULL)\n" "> > + if (!qp->wqe_wr_id_tbl)\n" "> > return -ENOMEM;\n" "> > qp->rqe_wr_id_tbl = kcalloc(qp->rq.max_cnt, sizeof(*qp->rqe_wr_id_tbl),\n" "> > GFP_KERNEL);\n" - "> > - if (qp->rqe_wr_id_tbl = NULL)\n" + "> > - if (qp->rqe_wr_id_tbl == NULL)\n" "> > + if (!qp->rqe_wr_id_tbl)\n" "> > return -ENOMEM;\n" "> >\n" @@ -81,7 +81,7 @@ "> > goto gen_err;\n" "> > }\n" "> > ocrdma_set_qp_init_params(qp, pd, attrs);\n" - "> > - if (udata = NULL)\n" + "> > - if (udata == NULL)\n" "> > + if (!udata)\n" "> > qp->cap_flags |= (OCRDMA_QP_MW_BIND | OCRDMA_QP_LKEY0 |\n" "> > OCRDMA_QP_FAST_REG);\n" @@ -90,7 +90,7 @@ "> > goto mbx_err;\n" "> >\n" "> > /* user space QP's wr_id table are managed in library */\n" - "> > - if (udata = NULL) {\n" + "> > - if (udata == NULL) {\n" "> > + if (!udata) {\n" "> > status = ocrdma_alloc_wr_id_tbl(qp);\n" "> > if (status)\n" @@ -99,12 +99,12 @@ "> > if (status)\n" "> > goto err;\n" "> >\n" - "> > - if (udata = NULL) {\n" + "> > - if (udata == NULL) {\n" "> > + if (!udata) {\n" "> > srq->rqe_wr_id_tbl = kcalloc(srq->rq.max_cnt,\n" "> > sizeof(*srq->rqe_wr_id_tbl),\n" "> > GFP_KERNEL);\n" - "> > - if (srq->rqe_wr_id_tbl = NULL)\n" + "> > - if (srq->rqe_wr_id_tbl == NULL)\n" "> > + if (!srq->rqe_wr_id_tbl)\n" "> > goto arm_err;\n" "> >\n" @@ -113,16 +113,16 @@ "> > srq->idx_bit_fields = kmalloc_array(srq->bit_fields_len,\n" "> > sizeof(*srq->idx_bit_fields),\n" "> > GFP_KERNEL);\n" - "> > - if (srq->idx_bit_fields = NULL)\n" + "> > - if (srq->idx_bit_fields == NULL)\n" "> > + if (!srq->idx_bit_fields)\n" "> > goto arm_err;\n" "> > memset(srq->idx_bit_fields, 0xff,\n" "> > srq->bit_fields_len * sizeof(*srq->idx_bit_fields));\n" "> > @@ -2878,7 +2878,7 @@ static int ocrdma_poll_hwcq(struct ocrdma_cq *cq, int num_entries,\n" - "> > if (qpn = 0)\n" + "> > if (qpn == 0)\n" "> > goto skip_cqe;\n" "> > qp = dev->qp_tbl[qpn];\n" - "> > - BUG_ON(qp = NULL);\n" + "> > - BUG_ON(qp == NULL);\n" "> > + BUG_ON(!qp);\n" "> >\n" "> > expand = is_cqe_for_sq(cqe)\n" @@ -135,4 +135,4 @@ "> the body of a message to majordomo@vger.kernel.org\n" > More majordomo info at http://vger.kernel.org/majordomo-info.html -2eb4850f681404d5e2949f3d7d5d9d2176b9252cedc1be7028cf0a16a2fdfe71 +1b3a7d555570503caeb46ab55f4ac3da582339508d24460aa41587d6abc93639
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.