Re: [Outreachy kernel] [PATCH 1/2] staging: bcm2835-camera: replace get_msg_context() with kzalloc

[Aishwarya Pant <aishpant@gmail.com>]

On Thu, Mar 09, 2017 at 02:36:51PM +0100, Greg KH wrote:
> On Wed, Mar 08, 2017 at 10:14:28AM +0530, Aishwarya Pant wrote:
> > This patch replaces function get_msg_context(..) with a kzalloc at
> > the caller. This is safe as the only usage found in mmal-vchiq.c has been
> > refactored.
> > 
> > Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> > ---
> >  .../staging/vc04_services/bcm2835-camera/mmal-vchiq.c    | 16 ++--------------
> >  1 file changed, 2 insertions(+), 14 deletions(-)
> 
> This, and the 2/2 patch do not apply at all to my tree :(
> 
> Please fix up and resend.

Hey

I checked this file. The definitions of get_msg_context(..) and
release_msg_context(..) have changed completely, they do more work than
a simple alloc and de-alloc. So these patches don't make sense anymore.

There is still scope to replace kmalloc + memset with a kzalloc, so I'll
do that and send a separate patch.

> 
> thanks,
> 
> greg k-h