All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: mchehab@kernel.org, devel@driverdev.osuosl.org,
	outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant
Date: Thu, 9 Mar 2017 17:45:41 +0100	[thread overview]
Message-ID: <20170309164541.GA12365@kroah.com> (raw)
In-Reply-To: <1488484322-5928-1-git-send-email-singhalsimran0@gmail.com>

On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote:
> This patch removes unnecessary typecast of c90 int constant.
> 
> WARNING: Unnecessary typecast of c90 int constant
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

The subject needs to say which driver is being touched here.  So this
would be:
	 [PATCH 1/7] staging: gc2235: Remove unnecessary typecast of c90 int constant

Please fix up for all of these and resend.

thanks,

greg k-h


      parent reply	other threads:[~2017-03-09 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 19:51 [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant simran singhal
2017-03-02 19:51 ` [PATCH 2/7] staging: media: Add blank line after a declaration simran singhal
2017-03-02 19:51 ` [PATCH 3/7] staging: media: Replace NULL with "!" simran singhal
2017-03-02 19:51 ` [PATCH 4/7] staging: media: Remove blank line before '}' and after '{' braces simran singhal
2017-03-02 19:52 ` [PATCH 5/7] staging: media: Remove multiple assignments simran singhal
2017-03-02 19:52 ` [PATCH 6/7] staging: media: Use x instead of x != NULL simran singhal
2017-03-02 19:52 ` [PATCH 7/7] staging: media: Do not use multiple blank lines simran singhal
2017-03-03 17:45 ` [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant Sakari Ailus
2017-03-03 18:23   ` SIMRAN SINGHAL
2017-03-03 18:37     ` [Outreachy kernel] " Julia Lawall
2017-03-09 16:45 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170309164541.GA12365@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.