Re: [PATCH 1/3] staging: bcm2835-camera: add check to avoid null pointer dereference

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Mar 09, 2017 at 11:43:28PM +0530, Aishwarya Pant wrote:
> This patch adds checks after memory allocation to avoid possible null
> pointer dereferences.
> 
> Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> ---
>  drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 6126919..a258a72 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -263,6 +263,9 @@ get_msg_context(struct vchiq_mmal_instance *instance)
>  	msg_context = kmalloc(sizeof(*msg_context), GFP_KERNEL);
>  	memset(msg_context, 0, sizeof(*msg_context));
>  
> +	if (!msg_context)
> +		return NULL;

But you just crashed one line above!

not good :(

greg k-h