From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove
Date: Fri, 10 Mar 2017 03:33:17 +0100 [thread overview]
Message-ID: <20170310023317.GJ22101@lunn.ch> (raw)
In-Reply-To: <20170309233324.18539-8-vivien.didelot@savoirfairelinux.com>
> -static int _mv88e6xxx_atu_cmd(struct mv88e6xxx_chip *chip, u16 fid, u16 cmd)
> -{
> - u16 val;
> - int err;
> -
> - if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_G1_ATU_FID)) {
> - err = mv88e6xxx_g1_write(chip, GLOBAL_ATU_FID, fid);
> - if (err)
> - return err;
I think this removal makes MV88E6XXX_FLAG_G1_ATU_FID unused. It should
be removed from mv88e6xxx.h as well.
Andrew
next prev parent reply other threads:[~2017-03-10 2:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 23:33 [PATCH net-next 00/14] net: dsa: mv88e6xxx: rework ATU support Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 01/14] net: dsa: mv88e6xxx: add port mask helper Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 02/14] net: dsa: mv88e6xxx: move ATU ageing time setter Vivien Didelot
2017-03-10 0:45 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All Vivien Didelot
2017-03-10 2:00 ` Andrew Lunn
2017-03-10 2:03 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Vivien Didelot
2017-03-10 2:27 ` Andrew Lunn
2017-03-11 20:55 ` Vivien Didelot
2017-03-11 23:40 ` Andrew Lunn
2017-03-13 14:59 ` Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 05/14] net: dsa: mv88e6xxx: rework ATU GetNext Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 06/14] net: dsa: mv88e6xxx: rework ATU Flush Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove Vivien Didelot
2017-03-10 2:33 ` Andrew Lunn [this message]
2017-03-09 23:33 ` [PATCH net-next 08/14] net: dsa: mv88e6xxx: rename new FID helper Vivien Didelot
2017-03-10 0:16 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 09/14] net: dsa: mv88e6xxx: rename the port vector member Vivien Didelot
2017-03-10 0:17 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 10/14] net: dsa: mv88e6xxx: rework port mode setup Vivien Didelot
2017-03-10 0:29 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 11/14] net: dsa: mv88e6xxx: fix port egress flooding mode Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 12/14] net: dsa: mv88e6xxx: add port ATU learn limit op Vivien Didelot
2017-03-10 0:37 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 13/14] net: dsa: mv88e6xxx: add port priority override op Vivien Didelot
2017-03-10 0:39 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 14/14] etherdevice: remove unused eth_addr_greater Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310023317.GJ22101@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.