From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pascal Mazon <pascal.mazon@6wind.com>
Subject: Re: [PATCH v3 1/4] net/tap: move private elements to
 external header
Date: Fri, 10 Mar 2017 10:40:35 +0100
Message-ID: <20170310104035.05ef6326@paques.dev.6wind.com>
References: <cover.1488819791.git.pascal.mazon@6wind.com>
 <cover.1488904425.git.pascal.mazon@6wind.com>
 <f1855c15861d0da20332596bca034bd432516c9e.1488904425.git.pascal.mazon@6wind.com>
 <fd9bab08-d1d1-83da-33be-cb3b231d0c9d@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: keith.wiles@intel.com, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 75575374F
 for <dev@dpdk.org>; Fri, 10 Mar 2017 10:41:12 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id v186so6312939wmd.0
 for <dev@dpdk.org>; Fri, 10 Mar 2017 01:41:12 -0800 (PST)
In-Reply-To: <fd9bab08-d1d1-83da-33be-cb3b231d0c9d@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 9 Mar 2017 15:28:31 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 3/7/2017 4:35 PM, Pascal Mazon wrote:
> > In the next patch, access to struct pmd_internals will be necessary
> > in tap_flow.c to store the flows.
> > 
> > Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
> > Acked-by: Olga Shern <olgas@mellanox.com>
> > ---
> >  drivers/net/tap/Makefile      |  1 +
> >  drivers/net/tap/rte_eth_tap.c | 34 ++------------------
> >  drivers/net/tap/tap.h         | 73
> > +++++++++++++++++++++++++++++++++++++++++++
> 
> tap.h is a generic name, I think rte_eth_tap.h fits better here.
> 
> <...>

I'm ok with that. I'll change it in my next version.