From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH 0/5] Thunderbolt GPU fixes Date: Fri, 10 Mar 2017 13:07:25 +0100 Message-ID: <20170310120725.GA24595@h08.hostsharing.net> References: <20170309150347.a4k4w2sclox2365t@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170309150347.a4k4w2sclox2365t-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Daniel Vetter , Darren Hart , Andy Shevchenko Cc: Michael Jamet , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Peter Wu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bjorn Helgaas , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Alex Deucher , Mika Westerberg , Christian Koenig , Ben Skeggs T24gVGh1LCBNYXIgMDksIDIwMTcgYXQgMDQ6MDM6NDdQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIEZlYiAyNCwgMjAxNyBhdCAwODoxOTo0NVBNICswMTAwLCBMdWthcyBX dW5uZXIgd3JvdGU6Cj4gPiBGaXggVGh1bmRlcmJvbHQtcmVsYXRlZCBpc3N1ZXMgaW4gYXBwbGUt Z211eCBhbmQgdmdhX3N3aXRjaGVyb286Cj4gPiAKPiA+IFBhdGNoIFsxLzVdICgiUmVjb2duaXpl IFRodW5kZXJib2x0IGRldmljZXMiKSBoYXMgYWxyZWFkeSBiZWVuIHN1YmplY3RlZAo+ID4gdG8g YSBmYWlyIGFtb3VudCBvZiBzY3J1dGlueSBvdmVyIGF0IGxpbnV4LXBjaUAsIEkndmUgc3VibWl0 dGVkIGl0IDUgdGltZXMKPiA+IHRvdGFsIHNpbmNlIE1heSAyMDE2LiAgV2l0aCBsdWNrIGl0IG1h eSBiZSBpbiBhY2stYWJsZSBzaGFwZSBub3cuCj4gPiAKPiA+IFBhdGNoIFsyLzVdIGFtZW5kcyBh cHBsZS1nbXV4IHRvIGhhbmRsZSBjb21iaW5lZCBEUC9UaHVuZGVyYm9sdCBwb3J0cwo+ID4gcHJv cGVybHkgb24gbmV3ZXIgTWFjQm9vayBQcm9zLgo+ID4gCj4gPiBQYXRjaGVzIFszLzVdIHRvIFs1 LzVdIGF2b2lkIHJlZ2lzdGVyaW5nIGV4dGVybmFsIFRodW5kZXJib2x0IEdQVXMgd2l0aAo+ID4g dmdhX3N3aXRjaGVyb286ICBEYXZlIEFpcmxpZSBkZXNpZ25lZCB2Z2Ffc3dpdGNoZXJvbyB0byBy ZWdpc3RlciBHUFVzCj4gPiB1bmNvbmRpdGlvbmFsbHkuICBTbyBpZiBhIGRlc2t0b3AgYm94IGhh cyBtdWx0aXBsZSBHUFVzLCB2Z2Ffc3dpdGNoZXJvbwo+ID4gd2lsbCBzZWUgbW9yZSB0aGFuIG9u ZSBkaXNjcmV0ZSBHUFUgYnV0IHRoYXQncyBub3QgYSBwcm9ibGVtIGJlY2F1c2Ugb24KPiA+IGRl c2t0b3AgYm94ZXMgbm8gaGFuZGxlciBpcyByZWdpc3RlcmVkIGFuZCB0aHVzIHZnYV9zd2l0Y2hl cm9vX2VuYWJsZSgpCj4gPiBpcyBuZXZlciBjYWxsZWQuICBIeWJyaWQgZ3JhcGhpY3MgbGFwdG9w cyBvbiB0aGUgb3RoZXIgaGFuZCBkbyByZWdpc3Rlcgo+ID4gYSBoYW5kbGVyLCBidXQgYXJlIGFz c3VtZWQgdG8gbmV2ZXIgcmVnaXN0ZXIgbW9yZSB0aGFuIG9uZSBkaXNjcmV0ZSBHUFUuCj4gPiBI b3dldmVyIG9uY2UgYSBUaHVuZGVyYm9sdCBlR1BVIGlzIGF0dGFjaGVkIHRvIGEgaHlicmlkIGdy YXBoaWNzIGxhcHRvcCwKPiA+IHRoYXQgYXNzdW1wdGlvbiBpcyBubyBsb25nZXIgdHJ1ZSBhbmQg dGhpbmdzIGdvIHNvdXRoIHdoZW4gdmdhX3N3aXRjaGVyb28KPiA+IHJ1bnRpbWUgc3VzcGVuZHMg dGhlIGV4dGVybmFsIGRpc2NyZXRlIEdQVSBhbmQgdGhlbiBjYWxscyB0aGUgaGFuZGxlciB0bwo+ ID4gY3V0IHBvd2VyIHRvIHRoZSBpbnRlcm5hbCBkaXNjcmV0ZSBHUFUuICBUaGUgZHJpdmVyIGZv ciB0aGUgaW50ZXJuYWwgR1BVCj4gPiB3aWxsIHNpdCB0aGVyZSBwdXp6bGVkIGFuZCB0eXBpY2Fs bHkgY2F1c2UgYSBsb2NrdXAuCltzbmlwXQo+ID4gSSd2ZSBwdXNoZWQgdGhlIHByZXNlbnQgc2Vy aWVzIHRvIEdpdEh1YiBpbiBjYXNlIGFueW9uZSBwcmVmZXJzIHJldmlld2luZwo+ID4gaXQgaW4g YSBHVUk6Cj4gPiBodHRwczovL2dpdGh1Yi5jb20vbDFrL2xpbnV4L2NvbW1pdHMvdGh1bmRlcmJv bHRfZ3B1X3YxCj4gCj4gRm9yIG1lcmdpbmcsIHNob3VsZCBJIHNtYXNoIHRoaXMgYWxsIGludG8g ZHJtLW1pc2M/IFRoZSBvbmx5IHRoaW5nIG91dHNpZGUKPiBpcyB0aGUgYXBwbGUtZ211eCBkcml2 ZXIgLi4uCgpNZXJnaW5nIHRocm91Z2ggZHJtLW1pc2Mgd291bGQgYmUgbG92ZWx5LiAgSG93ZXZl ciBJJ3ZlIHByZXBhcmVkIGEgdjIgb2YKcGF0Y2ggWzEvNV0gdG8gYWRkcmVzcyBCam9ybidzIGNv bW1lbnRzIChhbWVuZGVkIHRoZSBjb21taXQgbWVzc2FnZSBhbmQgYQpjb2RlIGNvbW1lbnQpLiAg SSdsbCByZXNwaW4gdGhlIHNlcmllcyB0aGlzIGV2ZW5pbmcgYW5kIGluY2x1ZGUgdGhlIGFja3MK SSd2ZSBjb2xsZWN0ZWQgc28gZmFyLgoKQERhcnJlbiAmIEFuZHk6ClBsZWFzZSBhY2sgcGF0Y2gg WzUvNV0gb2YgdGhpcyBzZXJpZXMsIGJhcnJpbmcgYW55IG9iamVjdGlvbnMuCgpJJ2xsIG1vdmUg dGhlIGFwcGxlLWdtdXggcGF0Y2ggdG8gdGhlIGVuZCBvZiB0aGUgc2VyaWVzLCBzbyBtZXJnaW5n IHRoYXQKb25lIGNhbiBiZSBwb3N0cG9uZWQgdW50aWwgRGFycmVuIGFuZCBBbmR5IGZpbmQgdGhl IHRpbWUgdG8gbG9vayBhdCBpdC4KClRoYW5rcyEKCkx1a2FzCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.hostsharing.net ([83.223.95.204]:36611 "EHLO mailout1.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934227AbdCJMHd (ORCPT ); Fri, 10 Mar 2017 07:07:33 -0500 Date: Fri, 10 Mar 2017 13:07:25 +0100 From: Lukas Wunner To: Daniel Vetter , Darren Hart , Andy Shevchenko Cc: dri-devel@lists.freedesktop.org, Michael Jamet , linux-pci@vger.kernel.org, amd-gfx@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, Alex Deucher , Ben Skeggs , nouveau@lists.freedesktop.org, Bjorn Helgaas , Mika Westerberg , Christian Koenig , Peter Wu Subject: Re: [PATCH 0/5] Thunderbolt GPU fixes Message-ID: <20170310120725.GA24595@h08.hostsharing.net> References: <20170309150347.a4k4w2sclox2365t@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170309150347.a4k4w2sclox2365t@phenom.ffwll.local> Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, Mar 09, 2017 at 04:03:47PM +0100, Daniel Vetter wrote: > On Fri, Feb 24, 2017 at 08:19:45PM +0100, Lukas Wunner wrote: > > Fix Thunderbolt-related issues in apple-gmux and vga_switcheroo: > > > > Patch [1/5] ("Recognize Thunderbolt devices") has already been subjected > > to a fair amount of scrutiny over at linux-pci@, I've submitted it 5 times > > total since May 2016. With luck it may be in ack-able shape now. > > > > Patch [2/5] amends apple-gmux to handle combined DP/Thunderbolt ports > > properly on newer MacBook Pros. > > > > Patches [3/5] to [5/5] avoid registering external Thunderbolt GPUs with > > vga_switcheroo: Dave Airlie designed vga_switcheroo to register GPUs > > unconditionally. So if a desktop box has multiple GPUs, vga_switcheroo > > will see more than one discrete GPU but that's not a problem because on > > desktop boxes no handler is registered and thus vga_switcheroo_enable() > > is never called. Hybrid graphics laptops on the other hand do register > > a handler, but are assumed to never register more than one discrete GPU. > > However once a Thunderbolt eGPU is attached to a hybrid graphics laptop, > > that assumption is no longer true and things go south when vga_switcheroo > > runtime suspends the external discrete GPU and then calls the handler to > > cut power to the internal discrete GPU. The driver for the internal GPU > > will sit there puzzled and typically cause a lockup. [snip] > > I've pushed the present series to GitHub in case anyone prefers reviewing > > it in a GUI: > > https://github.com/l1k/linux/commits/thunderbolt_gpu_v1 > > For merging, should I smash this all into drm-misc? The only thing outside > is the apple-gmux driver ... Merging through drm-misc would be lovely. However I've prepared a v2 of patch [1/5] to address Bjorn's comments (amended the commit message and a code comment). I'll respin the series this evening and include the acks I've collected so far. @Darren & Andy: Please ack patch [5/5] of this series, barring any objections. I'll move the apple-gmux patch to the end of the series, so merging that one can be postponed until Darren and Andy find the time to look at it. Thanks! Lukas