From: Vivek Goyal <vgoyal@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Mike Galbraith <efault@gmx.de>, Borislav Petkov <bp@alien8.de>,
"Tobin C. Harding" <me@tobin.cc>,
LKML <linux-kernel@vger.kernel.org>,
Nicholas Mc Guire <der.herr@hofr.at>,
x86@kernel.org, Dave Young <dyoung@redhat.com>,
Baoquan He <bhe@redhat.com>
Subject: Re: kexec, x86/purgatory: Cleanup the unholy mess
Date: Fri, 10 Mar 2017 10:05:30 -0500 [thread overview]
Message-ID: <20170310150530.GB20954@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1703101556220.3681@nanos>
On Fri, Mar 10, 2017 at 03:58:20PM +0100, Thomas Gleixner wrote:
> On Fri, 10 Mar 2017, Vivek Goyal wrote:
> > I think we probably will have to initialize these global variables in
> > purgatory itself and that puts them in .data section and relocation
> > works.
> >
> > That's how the code was intially. I initialized value of
> > purgatory_sha256_digest in the code and then did "readelf -a purgatory.o"
> > and symbol section index changed from COM to 3.
> >
> > 13: 0000000000000000 32 OBJECT GLOBAL DEFAULT 3
> > purgatory_sha256_digest
> >
> > [ 3] .data PROGBITS 0000000000000000 00000120
> > 0000000000000020 0000000000000000 WA 0 0 32
>
> Yeah, and then instead of doing it proper you relied on compiler/link magic
> which is unreliable, undocumented and uncomprehensible. But that's just
> compatible to the rest of kexec. Works for me is never a good engineering
> principle.
Agreed. That was not a very good idea. Thanks for fixing this.
Vivek
next prev parent reply other threads:[~2017-03-10 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 12:17 kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner
2017-03-10 13:47 ` Mike Galbraith
2017-03-10 13:57 ` Thomas Gleixner
2017-03-10 14:24 ` Vivek Goyal
2017-03-10 14:58 ` Thomas Gleixner
2017-03-10 15:05 ` Vivek Goyal [this message]
2017-03-10 14:31 ` Mike Galbraith
2017-03-10 14:56 ` Thomas Gleixner
2017-03-10 14:58 ` Mike Galbraith
2017-03-10 15:31 ` Thomas Gleixner
2017-03-10 18:13 ` Mike Galbraith
2017-03-10 20:13 ` [tip:x86/urgent] kexec, x86/purgatory: Unbreak it and clean it up tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310150530.GB20954@redhat.com \
--to=vgoyal@redhat.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=der.herr@hofr.at \
--cc=dyoung@redhat.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.