From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH] ASoC: Intel: Skylake: code cleanup for pin fixup limitation Date: Fri, 10 Mar 2017 22:24:44 +0530 Message-ID: <20170310165443.GW2843@localhost> References: <20170308084702.20558-1-takashi.sakamoto@miraclelinux.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by alsa0.perex.cz (Postfix) with ESMTP id 1004926583C for ; Fri, 10 Mar 2017 17:54:01 +0100 (CET) Content-Disposition: inline In-Reply-To: <20170308084702.20558-1-takashi.sakamoto@miraclelinux.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, ichiro.suzuki@miraclelinux.com, broonie@kernel.org, shreyas.nc@intel.com, jeeja.kp@intel.com, yukie.kato@miraclelinux.com List-Id: alsa-devel@alsa-project.org Hi Takashi-San, On Wed, Mar 08, 2017 at 05:47:02PM +0900, Takashi Sakamoto wrote: > As a commit 4cd9899f0d16 ("ASoC: Intel: Skylake: Add multiple pin > formats") describes, 'fixups is applied to pin 0 only'. On the other > hand, the commit left some codes as what they were. This might > confuses readers. > > This commit fixes the issue. This doesn't change driver behaviour at all. Thanks, this also looks good. So, Acked-by: Vinod Koul Tested-by: Subhransu S. Prusty > > Fixes: 4cd9899f0d16 ("ASoC: Intel: Skylake: Add multiple pin formats") > Signed-off-by: Takashi Sakamoto > --- > sound/soc/intel/skylake/skl-topology.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c > index f38f8e6..8651359 100644 > --- a/sound/soc/intel/skylake/skl-topology.c > +++ b/sound/soc/intel/skylake/skl-topology.c > @@ -310,13 +310,11 @@ static void skl_tplg_update_buffer_size(struct skl_sst *ctx, > multiplier = 5; > > mcfg->ibs = DIV_ROUND_UP(in_fmt->s_freq, 1000) * > - (mcfg->in_fmt->channels) * > - (mcfg->in_fmt->bit_depth >> 3) * > + in_fmt->channels * (in_fmt->bit_depth >> 3) * > multiplier; > > - mcfg->obs = DIV_ROUND_UP(mcfg->out_fmt->s_freq, 1000) * > - (mcfg->out_fmt->channels) * > - (mcfg->out_fmt->bit_depth >> 3) * > + mcfg->obs = DIV_ROUND_UP(out_fmt->s_freq, 1000) * > + out_fmt->channels * (out_fmt->bit_depth >> 3) * > multiplier; > } > > -- > 2.9.3 > -- ~Vinod