Re: [Outreachy kernel] [PATCH 2/2] staging: bcm2835-camera: remove anonymous field declarations

[Aishwarya Pant <aishpant@gmail.com>]

On Fri, Mar 10, 2017 at 05:50:54PM +0100, Julia Lawall wrote:
> On Fri, 10 Mar 2017, Aishwarya Pant wrote:
> 
> > Anonymous field declarations are error prone. This patch replaces
> > anonymous declarations with explicit field declarations for typedef
> > SERVICE_CREATION_T in vchiq_mmal_init(..)
> 
> Were you able to compile this file?

I delete the *.o files from the drivers and compiled them with the
allyesconfig. No errors.

> 
> julia
> 
> >
> > Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> > ---
> >  .../vc04_services/bcm2835-camera/mmal-vchiq.c        | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> > index 803095e..88b379f 100644
> > --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> > +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> > @@ -1977,16 +1977,16 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance)
> >  	static VCHI_CONNECTION_T *vchi_connection;
> >  	static VCHI_INSTANCE_T vchi_instance;
> >  	SERVICE_CREATION_T params = {
> > -		VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER),
> > -		VC_MMAL_SERVER_NAME,
> > -		vchi_connection,
> > -		0,		/* rx fifo size (unused) */
> > -		0,		/* tx fifo size (unused) */
> > -		service_callback,
> > -		NULL,		/* service callback parameter */
> > -		1,		/* unaligned bulk receives */
> > -		1,		/* unaligned bulk transmits */
> > -		0		/* want crc check on bulk transfers */
> > +		.version		= VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER),
> > +		.service_id		= VC_MMAL_SERVER_NAME,
> > +		.connection		= vchi_connection,
> > +		.rx_fifo_size		= 0,
> > +		.tx_fifo_size		= 0,
> > +		.callback		= service_callback,
> > +		.callback_param		= NULL,
> > +		.want_unaligned_bulk_rx = 1,
> > +		.want_unaligned_bulk_tx = 1,
> > +		.want_crc		= 0
> >  	};
> >
> >  	/* compile time checks to ensure structure size as they are
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a7acfee24fab685d28cc5bb088b2fe4288a4aa81.1489163547.git.aishpant%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >