Re: [morty][PATCH V2 1/5] weston: allow visual_id to be 0 to fix EGL config failure

[Denys Dmytriyenko <denys@ti.com>]

On Thu, Mar 09, 2017 at 04:27:33PM -0500, Eric Ruei wrote:
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
>  ...to-be-0.patch => 0002-Weston-Allow-visual_id-to-be-0.patch} | 10 +++++-----
>  .../recipes-graphics/wayland/weston_1.11.0.bbappend            |  3 ++-
>  2 files changed, 7 insertions(+), 6 deletions(-)
>  rename meta-arago-distro/recipes-graphics/wayland/weston/{0002-Weston1.9.0-Allow-visual_id-to-be-0.patch => 0002-Weston-Allow-visual_id-to-be-0.patch} (72%)
> 
> diff --git a/meta-arago-distro/recipes-graphics/wayland/weston/0002-Weston1.9.0-Allow-visual_id-to-be-0.patch b/meta-arago-distro/recipes-graphics/wayland/weston/0002-Weston-Allow-visual_id-to-be-0.patch
> similarity index 72%
> rename from meta-arago-distro/recipes-graphics/wayland/weston/0002-Weston1.9.0-Allow-visual_id-to-be-0.patch
> rename to meta-arago-distro/recipes-graphics/wayland/weston/0002-Weston-Allow-visual_id-to-be-0.patch
> index 72d067f..39c8401 100644
> --- a/meta-arago-distro/recipes-graphics/wayland/weston/0002-Weston1.9.0-Allow-visual_id-to-be-0.patch
> +++ b/meta-arago-distro/recipes-graphics/wayland/weston/0002-Weston-Allow-visual_id-to-be-0.patch
> @@ -1,7 +1,7 @@
> -From 27cf7d0c260fa4754a021e9f6f92f83e2c99f5f4 Mon Sep 17 00:00:00 2001
> +From 5b5de6a814b43ca023a92b85b407b3d061dbc64f Mon Sep 17 00:00:00 2001
>  From: Eric Ruei <e-ruei1@ti.com>
> -Date: Mon, 11 Jan 2016 11:59:19 -0500
> -Subject: [PATCH 2/2] Weston1.9.0: Allow visual_id to be 0
> +Date: Thu, 9 Mar 2017 14:32:24 -0500
> +Subject: [PATCH 2/4] Weston: Allow visual_id to be 0
>  
>  The inquiry of visual id from egl API eglGetConfigAttrib(EGL_NATIVE_VISUAL_ID)
>  is an optional feature. The visual id will be set to 0 if this feature is
> @@ -14,10 +14,10 @@ Signed-off-by: Eric Ruei <e-ruei1@ti.com>
>   1 file changed, 1 insertion(+), 1 deletion(-)
>  
>  diff --git a/src/gl-renderer.c b/src/gl-renderer.c
> -index d7231f4..e1b925e 100644
> +index 23c0cd7..4c1f170 100644
>  --- a/src/gl-renderer.c
>  +++ b/src/gl-renderer.c
> -@@ -2194,7 +2194,7 @@ match_config_to_visual(EGLDisplay egl_display,
> +@@ -2462,7 +2462,7 @@ match_config_to_visual(EGLDisplay egl_display,
>   				&id))
>   			continue;
>   
> diff --git a/meta-arago-distro/recipes-graphics/wayland/weston_1.11.0.bbappend b/meta-arago-distro/recipes-graphics/wayland/weston_1.11.0.bbappend
> index 60a752b..9a2c3a7 100644
> --- a/meta-arago-distro/recipes-graphics/wayland/weston_1.11.0.bbappend
> +++ b/meta-arago-distro/recipes-graphics/wayland/weston_1.11.0.bbappend
> @@ -2,7 +2,7 @@
>  PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev mtdev"
>  PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm udev libgbm mtdev"
>  
> -PR_append = ".arago17"
> +PR_append = ".arago18"

BTW, there's no need to bump PR in any of these cases.

In general, manual PR updates have been deprecated upstream for some time. 
It's not critical one way or another - i.e. it's not technically required any 
more, but it also doesn't hurt. Thus I was allowing it in patches to our 
layers, as people just got used to doing it. But if you ever submit anything 
upstream, you'll get asked to not bump PR.

There are still some corner cases, when it may help to do so, but in general, 
a central PR Service resolves those as well...

-- 
Denys


>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>  
> @@ -11,4 +11,5 @@ RDEPENDS_${PN} += "weston-conf"
>  
>  SRC_URI += " \
>  	file://0001-udev-seat-restrict-udev-enumeration-to-card0.patch \
> +	file://0002-Weston-Allow-visual_id-to-be-0.patch \
>  "
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago