Re: [Outreachy kernel] [PATCH 3/4] staging: wilc1000: Align the code

[Alison Schofield <amsfield22@gmail.com>]

On Fri, Mar 10, 2017 at 06:59:05PM +0200, Tamara Diaconita wrote:
> Improve code readability by deleting tabs and adding spaces to align the code.
> 
> Fixed the checkpath.pl issue:
> CHECK: Aligment should match open paranthesis.
> 
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
Hi Tamara,
This is a virtual v2, because I've seen it before.

These would need to be corrected - (if you keep this in set)
CHECK: 'Aligment' may be misspelled - perhaps 'Alignment'?
CHECK: 'paranthesis' may be misspelled - perhaps 'parenthesis'?
checkpath.pl -> checkpatch.pl

It seems like we're removing CHECK's on alignment and gaining
WARNINGs on lines over 80.

What did you think about reworking that else block, as per
yesterday email.  That would be more of a code logic change
and wouldn't belong in this patchset.  How about tossing this
patch from the set and plan to come back to it another time
and look at that else block.

alisons

> ---
>  drivers/staging/wilc1000/linux_wlan.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index 2eebc62..c65c5e8 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -870,12 +870,12 @@ static int wilc_mac_open(struct net_device *ndev)
>  				if (memcmp(wl->vif[i ^ 1]->bssid,
>  					   wl->vif[i ^ 1]->src_addr, 6))
>  					wilc_set_wfi_drv_handler(vif,
> -							 wilc_get_vif_idx(vif),
> -							 0);
> +								 wilc_get_vif_idx(vif),
> +								 0);
>  				else
>  					wilc_set_wfi_drv_handler(vif,
> -							 wilc_get_vif_idx(vif),
> -							 1);
> +								 wilc_get_vif_idx(vif),
> +								 1);
>  			}
>  			wilc_set_operation_mode(vif, vif->iftype);
>  
> -- 
> 2.9.3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170310165905.4131-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.