From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] android-xfstests: allow detection of SELinux
Date: Fri, 10 Mar 2017 19:47:50 -0800 [thread overview]
Message-ID: <20170311034750.GA619@zzz> (raw)
In-Reply-To: <20170311015736.vl2cj34cfnu34qp4@thunk.org>
On Fri, Mar 10, 2017 at 08:57:36PM -0500, Theodore Ts'o wrote:
> On Fri, Mar 10, 2017 at 04:53:06PM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > xfstests is supposed to disable the creation of SELinux xattrs because
> > this interferes with some tests (e.g. generic/062 and generic/377), but
> > this was not working on Android. For the android-xfstests portion of
> > the fix, make the following changes:
> >
> > 1. To stop the mount program from stripping the 'context' mount option,
> > mount selinuxfs and create an empty /etc/selinux/config. This makes the
> > is_selinux_enabled() function from libselinux return true.
> >
> > 2. To stop xfstests from thinking that SELinux is disabled, link
> > /usr/sbin/selinuxenabled to /bin/true. (Note: getting the real version
> > of selinuxenabled by adding selinux-utils to the chroot tarball would
> > also work, though no other programs from it are needed yet, and some
> > don't work in the chroot environment yet.)
> >
> > In combination with the xfstests patch to stop hard-coding SELinux
> > contexts in xfstests, this fixes the failing tests.
>
> Thanks!
>
> I think you're missing the list of tests this fixes here?
>
> - Ted
They're mentioned at the top: generic/062 and generic/377. There may be others
among tests not being run, but those were the ones I observed were fixed.
Eric
next prev parent reply other threads:[~2017-03-11 3:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 0:53 [PATCH] android-xfstests: allow detection of SELinux Eric Biggers
2017-03-11 1:57 ` Theodore Ts'o
2017-03-11 3:47 ` Eric Biggers [this message]
2017-04-27 18:16 ` Eric Biggers
2017-04-29 16:40 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170311034750.GA619@zzz \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.