Re: [Outreachy kernel] Re: [PATCH] staging: comedi: Compress return logic into one line.

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Greg KH <greg@kroah.com>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>,
	abbotti@mev.co.uk, hsweeten@visionengravers.com
Subject: Re: [Outreachy kernel] Re: [PATCH] staging: comedi: Compress return logic into one line.
Date: Sun, 12 Mar 2017 15:35:01 +0100	[thread overview]
Message-ID: <20170312143501.GB32168@kroah.com> (raw)
In-Reply-To: <0409aeaa-40e5-489c-bcd8-62e1b5724772@googlegroups.com>

On Sun, Mar 12, 2017 at 07:07:59AM -0700, Varsha Rao wrote:
> 
> 
>     That broke the driver :(
> 
> ï¿½
> 
>     Please be more careful in your review.
> 
> ï¿½ï¿½
> ï¿½ï¿½ï¿½ I had compiled it before submitting the patch and it did not cause any
> error or warning.
> ï¿½ï¿½ï¿½ Is there something else to be done?

Yes, you need to look at the logic that you are writing/changing to
determine that it is not incorrect.  This is valid C code, so no build
warning will happen, it's just the logic is totally wrong :)

You do see the problem, right?  If not, please take the time to read it
and figure out what is going on here, as it's important to know.

thanks,

greg k-h

next prev parent reply	other threads:[~2017-03-12 14:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12 12:31 [PATCH] staging: comedi: Compress return logic into one line Varsha Rao
2017-03-12 12:35 ` [Outreachy kernel] " Julia Lawall
2017-03-12 13:53   ` Varsha Rao
2017-03-12 13:55 ` Greg Kroah-Hartman
2017-03-12 14:07   ` Varsha Rao
2017-03-12 14:35     ` Greg KH [this message]
2017-03-12 14:35     ` [Outreachy kernel] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312143501.GB32168@kroah.com \
    --to=greg@kroah.com \
    --cc=abbotti@mev.co.uk \
    --cc=hsweeten@visionengravers.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=rvarsha016@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.