From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] drm/i915: annote drop_caches debugfs interface with lockdep Date: Mon, 13 Mar 2017 09:30:41 +0100 Message-ID: <20170313083041.GH3343@twins.programming.kicks-ass.net> References: <20170312192716.15172-1-daniel.vetter@ffwll.ch> <20170312205340.16202-1-daniel.vetter@ffwll.ch> <20170313080157.GF3343@twins.programming.kicks-ass.net> <20170313081517.7gpljiircaq7dkbl@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C9196E35B for ; Mon, 13 Mar 2017 08:30:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170313081517.7gpljiircaq7dkbl@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel Graphics Development , Chris Wilson , Ingo Molnar , linux-kernel@vger.kernel.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTMsIDIwMTcgYXQgMDk6MTU6MTdBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBNb24sIE1hciAxMywgMjAxNyBhdCAwOTowMTo1N0FNICswMTAwLCBQZXRlciBa aWpsc3RyYSB3cm90ZToKPiA+IE9uIFN1biwgTWFyIDEyLCAyMDE3IGF0IDA5OjUzOjQwUE0gKzAx MDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiAKPiA+ID4gUGV0ZXIvSW5nbywKPiA+ID4gCj4g PiA+IFdlIHdhbnQgdGhpcyB0byB2YWxpZGF0ZSB0aGUgaTkxNSBzaHJpbmtlciBsb2NraW5nIGlu IG91ciBmYXN0IHRlc3RzCj4gPiA+IHdpdGhvdXQgdGhyYXNoaW5nIGJhZGx5ICh0aGF0IHRha2Vz IHRvbyBsb25nLCB3ZSBjYW4gb25seSB0aHJhc2ggaW4KPiA+ID4gdGhlIGV4dGVuZGVkIHJ1bnMp LiBDYW4geW91IHBscyB0YWtlIGEgbG9vayBhbmQgaWYgaXQncyBvayBhY2sgZm9yCj4gPiA+IG1l cmdpbmcgdGhyb3VnaCBkcm0taW50ZWwuZ2l0Pwo+ID4gCj4gPiBIdXJtLCBJIHdhcyBnb2luZyB0 byByZXdvcmsgYWxsIHRoYXQgc29vbmlzaDsgaGF2ZSBhIGxvb2sgaGVyZToKPiA+IAo+ID4gIGh0 dHBzOi8vbGttbC5rZXJuZWwub3JnL3IvMjAxNzAzMDIxMzQwMzEuR0c2NTM2QHR3aW5zLnByb2dy YW1taW5nLmtpY2tzLWFzcy5uZXQKPiA+IAo+ID4gVGhlIGltbWVkaWF0ZSBwcm9ibGVtIGlzIHRo YXQgSSBtYWRlIHRoZSBhbm5vdGF0aW9uIHByaXZhdGUgdG8gbW0vCj4gPiB0aGVyZSwgSSBzdXBw b3NlIEkgY291bGQgZml4IHRoYXQuCj4gCj4gWWVhaCwgd2UnZCByZWFsbHkgbGlrZSB0byBoYXZl IHRoYXQsIGFuZCBldmVuIHdoZW4gc3dpdGNoZWQgdG8gYQo+IGxvY2tkZXBfbWFwIGluc3RlYWQg b2YgcmV1c2luZyB0aGUgY29udGV4dCBzdHVmZiB0aGUgc2VtYW50aWMgaW50ZXJmYWNlCj4gd291 bGQgYmUgdGhlIHNhbWUgKGFuZCBJIHRoaW5rIHdlIHNob3VsZCBrZWVwIHRoZSBnZnBfZmxhZ3Mg c3R1ZmYsIGluIGNhc2UKPiBzb21lb25lIGFkZHMgYSBuZXN0aW5nIGxvY2tkZXAgbWFwIGZvciBH RlBfSU8pLgo+IAo+IERvIHlvdSB3YW50IGEgdG9waWMgYnJhbmNoIHdpdGgganVzdCB0aGlzIHBh dGNoICh0aGUgc2hyaW5rX2FsbCBpcyBuZXcgc28KPiB0aGVyZSB3aWxsIGJlIGEgY29uZmxpY3Qg YW5kIHdlIGNhbid0IG1lZ2UgaXQgdGhyb3VnaCBvbmUgdHJlZSBhbG9uZSkgc28KPiB0aGF0IHlv dSBjYW4gcmVmYWN0b3IgdGhpbmdzIHdpdGggaTkxNSBpbmNsdWRlZD8KCkp1c3QgdGFrZSB5b3Vy IHBhdGNoOyBJJ2xsIHNvcnQgaXQgb3V0IHdoZW4gSSBnZXQgdGltZSBmb3IgdGhpbmdzIGFuZAp0 YWtlIGk5MTUgYWxvbmcgZm9yIHRoZSByaWRlLgoKQWNrZWQtYnk6IFBldGVyIFppamxzdHJhIChJ bnRlbCkgPHBldGVyekBpbmZyYWRlYWQub3JnPgoKVGhhbmtzIQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751489AbdCMIax (ORCPT ); Mon, 13 Mar 2017 04:30:53 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:33471 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbdCMIap (ORCPT ); Mon, 13 Mar 2017 04:30:45 -0400 Date: Mon, 13 Mar 2017 09:30:41 +0100 From: Peter Zijlstra To: Intel Graphics Development , Chris Wilson , Ingo Molnar , linux-kernel@vger.kernel.org, Daniel Vetter Subject: Re: [PATCH] drm/i915: annote drop_caches debugfs interface with lockdep Message-ID: <20170313083041.GH3343@twins.programming.kicks-ass.net> References: <20170312192716.15172-1-daniel.vetter@ffwll.ch> <20170312205340.16202-1-daniel.vetter@ffwll.ch> <20170313080157.GF3343@twins.programming.kicks-ass.net> <20170313081517.7gpljiircaq7dkbl@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170313081517.7gpljiircaq7dkbl@phenom.ffwll.local> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2017 at 09:15:17AM +0100, Daniel Vetter wrote: > On Mon, Mar 13, 2017 at 09:01:57AM +0100, Peter Zijlstra wrote: > > On Sun, Mar 12, 2017 at 09:53:40PM +0100, Daniel Vetter wrote: > > > > > Peter/Ingo, > > > > > > We want this to validate the i915 shrinker locking in our fast tests > > > without thrashing badly (that takes too long, we can only thrash in > > > the extended runs). Can you pls take a look and if it's ok ack for > > > merging through drm-intel.git? > > > > Hurm, I was going to rework all that soonish; have a look here: > > > > https://lkml.kernel.org/r/20170302134031.GG6536@twins.programming.kicks-ass.net > > > > The immediate problem is that I made the annotation private to mm/ > > there, I suppose I could fix that. > > Yeah, we'd really like to have that, and even when switched to a > lockdep_map instead of reusing the context stuff the semantic interface > would be the same (and I think we should keep the gfp_flags stuff, in case > someone adds a nesting lockdep map for GFP_IO). > > Do you want a topic branch with just this patch (the shrink_all is new so > there will be a conflict and we can't mege it through one tree alone) so > that you can refactor things with i915 included? Just take your patch; I'll sort it out when I get time for things and take i915 along for the ride. Acked-by: Peter Zijlstra (Intel) Thanks!