All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: mpatocka@redhat.com
Cc: dm-devel@redhat.com
Subject: [bug report] dm: add integrity target
Date: Mon, 13 Mar 2017 13:01:23 +0300	[thread overview]
Message-ID: <20170313100123.GA14298@mwanda> (raw)

Hello Mikulas Patocka,

The patch dfab77c854fc: "dm: add integrity target" from Jan 4, 2017,
leads to the following static checker warning:

	drivers/md/dm-integrity.c:2653 dm_integrity_ctr()
	warn: always true condition '(ic->sb->log2_interleave_sectors != -1) => (0-255 != (-1))'

drivers/md/dm-integrity.c
  2647          if (le16_to_cpu(ic->sb->integrity_tag_size) != ic->tag_size) {
  2648                  r = -EINVAL;
  2649                  ti->error = "Invalid tag size";
  2650                  goto bad;
  2651          }
  2652          /* make sure that ti->max_io_len doesn't overflow */
  2653          if (ic->sb->log2_interleave_sectors != -1 && (ic->sb->log2_interleave_sectors < MIN_INTERLEAVE_SECTORS || ic->sb->log2_interleave_sectors > MAX_INTERLEAVE_SECTORS)) {
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Impossible!  Also this line is really really really long so it doesn't
even fit in my email client.  It's like a million characters long.

  2654                  r = -EINVAL;
  2655                  ti->error = "Invalid interleave_sectors in the superblock";
  2656                  goto bad;
  2657          }
 

regards,
dan carpenter

             reply	other threads:[~2017-03-13 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 10:01 Dan Carpenter [this message]
2017-03-15 12:23 ` [bug report] dm: add integrity target Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313100123.GA14298@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.