From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: Force fake conntrack entry to be at least 8 bytes aligned
Date: Mon, 13 Mar 2017 13:33:32 +0100 [thread overview]
Message-ID: <20170313123332.GA6790@salvia> (raw)
In-Reply-To: <20170311091222.GA24201@breakpoint.cc>
On Sat, Mar 11, 2017 at 10:12:22AM +0100, Florian Westphal wrote:
> Steven Rostedt (VMware) <rostedt@goodmis.org> wrote:
> > Since the nfct and nfctinfo have been combined, the nf_conn structure
> > must be at least 8 bytes aligned, as the 3 LSB bits are used for the
> > nfctinfo. But there's a fake nf_conn structure to denote untracked
> > connections, which is created by a PER_CPU construct. This does not
> > guarantee that it will be 8 bytes aligned and can break the logic in
> > determining the correct nfctinfo.
> >
> > I triggered this on a 32bit machine with the following error:
> [..]
>
> Ugh. Originally I had planned to also submit followup changes
> to get rid of the untracked objects but that part got delayed.
>
> > By using DEFINE/DECLARE_PER_CPU_ALIGNED we can enforce at least 8 byte
> > alignment as all cache line sizes are at least 8 bytes or more.
>
> Thanks for fixing this!
>
> Acked-by: Florian Westphal <fw@strlen.de>
Applied, thanks.
next prev parent reply other threads:[~2017-03-13 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 5:25 [PATCH] netfilter: Force fake conntrack entry to be at least 8 bytes aligned Steven Rostedt (VMware)
2017-03-11 9:12 ` Florian Westphal
2017-03-13 12:33 ` Pablo Neira Ayuso [this message]
2017-03-13 12:36 ` Pablo Neira Ayuso
2017-03-13 12:41 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313123332.GA6790@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.