All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alin Nastac <alin.nastac@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: Parse ICMPv6 redirects
Date: Mon, 13 Mar 2017 13:40:50 +0100	[thread overview]
Message-ID: <20170313124050.GA23998@salvia> (raw)
In-Reply-To: <1488880843-9352-1-git-send-email-alin.nastac@gmail.com>

Hi Alin,

On Tue, Mar 07, 2017 at 11:00:43AM +0100, Alin Nastac wrote:
> Extract IPv6 packet that triggered the sending of redirect message from
> ICMPv6 Redirected Header option and check if conntrack table contain such
> connection. Mark redirect packet as RELATED if a matching connection is found.

I think we need a sysctl to enable this on demand, eg.
'nf_conntrack_icmpv6_accept_redirects'

This is changing the default behaviour, my main concern here is that
filtering policies not accepting redirects will now make it via
RELATED.

I would prefer the user explicitly requests this.

Let me know, thanks!

  reply	other threads:[~2017-03-13 12:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 10:00 [PATCH v2] netfilter: Parse ICMPv6 redirects Alin Nastac
2017-03-13 12:40 ` Pablo Neira Ayuso [this message]
2017-03-13 13:17   ` Alin Năstac
2017-03-13 13:44     ` Pablo Neira Ayuso
2017-03-13 14:17       ` Alin Năstac
2017-03-13 17:00         ` Pablo Neira Ayuso
2017-03-13 17:49           ` Alin Năstac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313124050.GA23998@salvia \
    --to=pablo@netfilter.org \
    --cc=alin.nastac@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.