From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] tpm: Add sysfs interface to show TPM family version Date: Mon, 13 Mar 2017 15:31:57 +0100 Message-ID: <20170313143157.GE748@lunn.ch> References: <1489396817-24855-1-git-send-email-Meng.Li@windriver.com> <20170313115415.2czyr4woaq4h3ncr@intel.com> <529F9A9100AE8045A7A5B5A00A39FBB83DE9325F@ALA-MBC.corp.ad.wrs.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <529F9A9100AE8045A7A5B5A00A39FBB83DE9325F-/c0cZIGrDsgyzarUywkIaosyD1qQU09I@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Li, Meng" Cc: "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Mar 13, 2017 at 12:54:24PM +0000, Li, Meng wrote: > > > > -----Original Message----- > > From: Jarkko Sakkinen [mailto:jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org] > > Sent: Monday, March 13, 2017 7:54 PM > > To: Li, Meng > > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; peterhuewe-Mmb7MZpHnFY@public.gmane.org; > > tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org; jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org; tpmdd- > > devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > > Subject: Re: [PATCH] tpm: Add sysfs interface to show TPM family version > > > > On Mon, Mar 13, 2017 at 05:20:17PM +0800, Meng.Li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org wrote: > > > From: Limeng > > > > > > So far, there is not a sysfs interface for user space code to check > > > the TPM family version(TPM1.x or TPM2). So, add a file named > > > description in /sys/class/tpm/tpmX/ to show it. > > > > > > Signed-off-by: Meng Li > > > --- > > > > Is this the first or which version of the patch is this? Version number and > > changelog are missing :/ > > Hi Jarkko, > > This is the second version of this patch. The first one is reviewed by Peter who give out some good advices. > > It is my first time to submit patch to upstream(main line), A tip for you then. Wait at least one day between patch versions. That gives people time to comment on your patches, and you can fix many different issues at once. > and I am not very clear with the submitting rule. A good start is: Documentation/process/submitting-patches.rst > So, could you please give me a template to record the version and changing log? After the --- write one line per change you made from the previous version. Also, v3 should also contain the v2 change history etc... Picking a random example from the web: http://patchwork.ozlabs.org/patch/710615/ Andrew ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753375AbdCMOcN (ORCPT ); Mon, 13 Mar 2017 10:32:13 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:45969 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753148AbdCMOcF (ORCPT ); Mon, 13 Mar 2017 10:32:05 -0400 Date: Mon, 13 Mar 2017 15:31:57 +0100 From: Andrew Lunn To: "Li, Meng" Cc: Jarkko Sakkinen , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: Re: [tpmdd-devel] [PATCH] tpm: Add sysfs interface to show TPM family version Message-ID: <20170313143157.GE748@lunn.ch> References: <1489396817-24855-1-git-send-email-Meng.Li@windriver.com> <20170313115415.2czyr4woaq4h3ncr@intel.com> <529F9A9100AE8045A7A5B5A00A39FBB83DE9325F@ALA-MBC.corp.ad.wrs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <529F9A9100AE8045A7A5B5A00A39FBB83DE9325F@ALA-MBC.corp.ad.wrs.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2017 at 12:54:24PM +0000, Li, Meng wrote: > > > > -----Original Message----- > > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com] > > Sent: Monday, March 13, 2017 7:54 PM > > To: Li, Meng > > Cc: linux-kernel@vger.kernel.org; peterhuewe@gmx.de; > > tpmdd@selhorst.net; jgunthorpe@obsidianresearch.com; tpmdd- > > devel@lists.sourceforge.net > > Subject: Re: [PATCH] tpm: Add sysfs interface to show TPM family version > > > > On Mon, Mar 13, 2017 at 05:20:17PM +0800, Meng.Li@windriver.com wrote: > > > From: Limeng > > > > > > So far, there is not a sysfs interface for user space code to check > > > the TPM family version(TPM1.x or TPM2). So, add a file named > > > description in /sys/class/tpm/tpmX/ to show it. > > > > > > Signed-off-by: Meng Li > > > --- > > > > Is this the first or which version of the patch is this? Version number and > > changelog are missing :/ > > Hi Jarkko, > > This is the second version of this patch. The first one is reviewed by Peter who give out some good advices. > > It is my first time to submit patch to upstream(main line), A tip for you then. Wait at least one day between patch versions. That gives people time to comment on your patches, and you can fix many different issues at once. > and I am not very clear with the submitting rule. A good start is: Documentation/process/submitting-patches.rst > So, could you please give me a template to record the version and changing log? After the --- write one line per change you made from the previous version. Also, v3 should also contain the v2 change history etc... Picking a random example from the web: http://patchwork.ozlabs.org/patch/710615/ Andrew