From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com
Cc: fio@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 1/7] Make check_mount_writes() test appropriate device types
Date: Mon, 13 Mar 2017 12:27:52 -0600 [thread overview]
Message-ID: <20170313182752.GC23256@kernel.dk> (raw)
In-Reply-To: <20170313181503.33322-1-tkusumi@tuxera.com>
On Mon, Mar 13 2017, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> There are platforms that use chrdev (instead of blkdev) for block
> devices, thus check_mount_writes() needs to test an appropriate file
> type(s) for potential mounted devices.
>
> fio has had a macro FIO_HAVE_CHARDEV_SIZE basically for those using
> chrdev for block devices, and this macro can be used here as well.
>
> In FreeBSD and several others, blkdev is no longer used as a file type,
> so it's safe to only test FIO_TYPE_CHAR if FIO_HAVE_CHARDEV_SIZE is
> defined, but this commit leaves FIO_TYPE_BLOCK test since some
> platforms may have/use both for block devices (not sure if exist).
Applied this, and 2-6. Please resend 7/7 with a better commit log.
--
Jens Axboe
prev parent reply other threads:[~2017-03-13 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 18:14 [PATCH 1/7] Make check_mount_writes() test appropriate device types kusumi.tomohiro
2017-03-13 18:14 ` [PATCH 2/7] HOWTO: Add note/exception on allow_mounted_write= kusumi.tomohiro
2017-03-13 18:26 ` Jens Axboe
2017-03-13 18:14 ` [PATCH 3/7] Minor fixup for page cache invalidation debug prints kusumi.tomohiro
2017-03-13 18:15 ` [PATCH 4/7] Use ENOTSUP if OS doesn't support blkdev page cache invalidation kusumi.tomohiro
2017-03-13 18:15 ` [PATCH 5/7] Fix errval variable to be positive errno value kusumi.tomohiro
2017-03-13 18:15 ` [PATCH 6/7] manpage: Add URL links to HOWTO/README kusumi.tomohiro
2017-03-13 18:15 ` [PATCH 7/7] Apply outbox patch from FreeBSD ports kusumi.tomohiro
2017-03-13 18:26 ` Jens Axboe
2017-03-13 18:27 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313182752.GC23256@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=tkusumi@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.