From: me@tobin.cc (Tobin C. Harding)
To: kernelnewbies@lists.kernelnewbies.org
Subject: return codes
Date: Tue, 14 Mar 2017 13:45:49 +1100 [thread overview]
Message-ID: <20170314024549.GD25311@eros> (raw)
In-Reply-To: <20170314020851.GA26463@kroah.com>
On Tue, Mar 14, 2017 at 10:08:51AM +0800, Greg KH wrote:
> On Tue, Mar 14, 2017 at 01:03:07PM +1100, Tobin C. Harding wrote:
> > On investigating call sites for 'return' in drivers/staging/ks7010/
> > it can be seen that a number of functions us *custom* (positive)
> > integers to indicate error. Notwithstanding that they are positive, is
> > this ok for code in the kernel (i.e in order to get out of staging
> > does this need to be changed)? Functions in question have internal linkage
> > and the error code is used for debug messages.
> >
> > Should these be
> >
> > A) left alone
> > B) made negative
> > C) changed to use standard error codes (i.e -ENOMEM etc)
>
> C) please
Awesome.
thanks,
Tobin.
prev parent reply other threads:[~2017-03-14 2:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 2:03 return codes Tobin C. Harding
2017-03-14 2:08 ` Greg KH
2017-03-14 2:45 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314024549.GD25311@eros \
--to=me@tobin.cc \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.