From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 14 Mar 2017 09:29:16 +0100 (CET) Received: from localhost.localdomain ([127.0.0.1]:52782 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23994768AbdCNI3Hi0NIp (ORCPT ); Tue, 14 Mar 2017 09:29:07 +0100 Received: from h7.dl5rb.org.uk (localhost [127.0.0.1]) by h7.dl5rb.org.uk (8.15.2/8.14.8) with ESMTP id v2E8T6OD015770; Tue, 14 Mar 2017 09:29:06 +0100 Received: (from ralf@localhost) by h7.dl5rb.org.uk (8.15.2/8.15.2/Submit) id v2E8T6h0015769; Tue, 14 Mar 2017 09:29:06 +0100 Date: Tue, 14 Mar 2017 09:29:06 +0100 From: Ralf Baechle To: Marcin Nowakowski Cc: Florian Fainelli , linux-mips@linux-mips.org Subject: Re: [PATCH 0/2] cpu-features.h rename Message-ID: <20170314082906.GG26432@linux-mips.org> References: <1489412018-30387-1-git-send-email-marcin.nowakowski@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 57198 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Mar 14, 2017 at 08:40:21AM +0100, Marcin Nowakowski wrote: > On 13.03.2017 18:08, Florian Fainelli wrote: > > On 03/13/2017 06:33 AM, Marcin Nowakowski wrote: > > > Since the introduction of GENERIC_CPU_AUTOPROBE > > > (https://patchwork.linux-mips.org/patch/15395/) we've got 2 very similarily > > > named headers: cpu-features.h and cpufeature.h. > > > Since the latter is used by all platforms that implement > > > GENERIC_CPU_AUTOPROBE functionality, it's better to rename the MIPS-specific > > > cpu-features.h. > > > > > > Marcin Nowakowski (2): > > > MIPS: mach-rm: Remove recursive include of cpu-feature-overrides.h > > > MIPS: rename cpu-features.h -> cpucaps.h > > > > That's a lot of churn that could cause some good headaches in > > backporting stable changes affecting cpu-feature-overrides.h. > > > > Can we just do the cpu-features.h -> cpucaps.h rename and keep > > cpu-feature-overrides.h around? > > That's of course possible, but I think it would make the naming quite > confusing as well, as it would be very unclear for any reader as to why a > 'cpu-feature-overrides' overrides 'cpucaps'. > > I've looked at the change history of these files and most receive very > little updates (which is hardly surprising given the changes are done mostly > during initial integration of a new cpu or soon after), and none of the > changes in those files were marked for stable. I think it's safe to assume > that this pattern is not likely to change, would you agree? I've noticed the same pattern - and it's a little concerning. Not adding values for later features means the'll probably be runtime detected resulting in a bigger, slower kernel. Ralf