All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: mshan <educha997@gmail.com>
Cc: gregkh@linuxfoundation.org, domdevlin@free.fr,
	bhumirks@gmail.com, chopin.simon@gmail.com,
	mohsinshan1k@gmail.com, peter@hurleysoftware.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues.
Date: Tue, 14 Mar 2017 12:40:12 +0300	[thread overview]
Message-ID: <20170314094011.GM4136@mwanda> (raw)
In-Reply-To: <1489467134-6455-1-git-send-email-mohsinshan1k@gmail.com>

On Mon, Mar 13, 2017 at 09:52:14PM -0700, mshan wrote:
> Signed-off-by: mshan <mohsinshan1k@gmail.com>
> ---
>  drivers/staging/fwserial/fwserial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> index 41a49c8..d693c03 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -98,7 +98,7 @@ struct fwtty_transaction {
>  	};
>  };
>  
> -#define to_device(a, b)			(a->b)
> +#define to_device(a, b)			((a)->(b))

This macro is silly.  Just delete it.

regards,
dan carpenter

  parent reply	other threads:[~2017-03-14  9:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14  4:52 [PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues mshan
2017-03-14  5:47 ` Greg KH
2017-03-14  9:40 ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-03-14  6:02 Coding Style fix in drivers/staging/fwserial mshan
2017-03-14  6:02 ` [PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues mshan
2017-03-14  9:46   ` Dan Carpenter
2017-03-15  4:00   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170314094011.GM4136@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=bhumirks@gmail.com \
    --cc=chopin.simon@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=domdevlin@free.fr \
    --cc=educha997@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohsinshan1k@gmail.com \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.