All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Matthias May <matthias.may@neratec.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Jason Cobham <jcobham@questertangent.com>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time
Date: Tue, 14 Mar 2017 15:18:56 +0100	[thread overview]
Message-ID: <20170314141856.GG14183@lunn.ch> (raw)
In-Reply-To: <87inncj71i.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>

On Tue, Mar 14, 2017 at 09:56:41AM -0400, Vivien Didelot wrote:
> Hi Andrew,
> 
> Andrew Lunn <andrew@lunn.ch> writes:
> 
> >> The never ever seeing R/W failure on MDIO bus is not exactly accurate.
> >> We had with art (atheros calibration tool) the problem that interrupts
> >> were being disabled which lead to MDIO operations running into
> >> timout/failing.
> >
> > Yes, i've seen similar with power management bugs for the MDIO
> > driver. But you get a cascade of failures, lots of warnings and error
> > prints, it is clear something bad has happened, and the switch is in
> > an inconsistent state. So having one more debug print which is also
> > inconsistent does no really harm.
> >
> > Anyway, this whole conversation has taken more effort than just making
> > this simple change to remove a few lines of code. So lets drop it and
> > move on.
> 
> I don't understand nor agree with the fact that sometimes it's OK to not
> check for errors, based on one developer assumptions. Not checking
> return code is wrong and very likely error-prone.

Please go back and look what i said. I did check the error code, in
that it gets returned to the caller. I just don't check it before
printing the debug.

But as i said, lets drop this whole topic.

    Andrew

  reply	other threads:[~2017-03-14 14:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 19:20 [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Vivien Didelot
2017-03-13 22:39 ` Andrew Lunn
2017-03-13 22:42   ` Florian Fainelli
2017-03-13 22:58     ` Andrew Lunn
2017-03-14 11:12       ` Matthias May
2017-03-14 12:05         ` Andrew Lunn
2017-03-14 13:56           ` Vivien Didelot
2017-03-14 14:18             ` Andrew Lunn [this message]
2017-03-28 18:13 ` Vivien Didelot
2017-03-29  4:55   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170314141856.GG14183@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jcobham@questertangent.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.may@neratec.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.