From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: paul@pwsan.com, bcousson@baylibre.com, t-kristo@ti.com,
nsekhar@ti.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: OMAP2+ hwmod: Allow modules to disable HW_AUTO
Date: Tue, 14 Mar 2017 08:48:44 -0700 [thread overview]
Message-ID: <20170314154843.GD20572@atomide.com> (raw)
In-Reply-To: <1489405996-10718-3-git-send-email-rogerq@ti.com>
* Roger Quadros <rogerq@ti.com> [170313 04:55]:
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -2149,7 +2149,7 @@ static int _idle(struct omap_hwmod *oh)
> _idle_sysc(oh);
> _del_initiator_dep(oh, mpu_oh);
>
> - if (oh->clkdm)
> + if (oh->clkdm && !(oh->flags & HWMOD_CLKDM_NOAUTO))
> clkdm_deny_idle(oh->clkdm);
>
> if (oh->flags & HWMOD_BLOCK_WFI)
Is this change to _idle() really needed? It seems that the
clkdm_deny_idle() there is paired with the clkdm_allow_idle()
later on in the same function?
Regards,
Tony
next prev parent reply other threads:[~2017-03-14 15:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 11:53 [PATCH 0/4] ARM: DRA7: Fix DCAN1 stuck-in-transition Roger Quadros
2017-03-13 11:53 ` Roger Quadros
2017-03-13 11:53 ` [PATCH 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags Roger Quadros
2017-03-13 11:53 ` Roger Quadros
2017-03-13 13:35 ` Sekhar Nori
2017-03-13 13:35 ` Sekhar Nori
2017-03-14 10:49 ` Roger Quadros
2017-03-14 10:49 ` Roger Quadros
2017-03-14 12:07 ` [PATCH v2 " Roger Quadros
2017-03-14 12:07 ` Roger Quadros
2017-03-13 11:53 ` [PATCH 2/4] ARM: OMAP2+ hwmod: Allow modules to disable HW_AUTO Roger Quadros
2017-03-13 11:53 ` Roger Quadros
2017-03-14 15:48 ` Tony Lindgren [this message]
2017-03-16 7:59 ` Roger Quadros
2017-03-16 7:59 ` Roger Quadros
2017-03-16 8:04 ` Roger Quadros
2017-03-16 8:04 ` Roger Quadros
2017-03-16 15:24 ` Tony Lindgren
2017-03-17 8:39 ` Roger Quadros
2017-03-17 8:39 ` Roger Quadros
2017-03-17 8:58 ` [PATCH v2 " Roger Quadros
2017-03-17 8:58 ` Roger Quadros
2017-03-23 20:59 ` Tony Lindgren
2017-03-13 11:53 ` [PATCH 3/4] ARM: DRA7: hwmod: Fix DCAN1 stuck in transition Roger Quadros
2017-03-13 11:53 ` Roger Quadros
2017-03-13 11:53 ` [PATCH 4/4] ARM: DRA7: hwmod_data: Prevent wait_target_disable error for usb_otg_ss Roger Quadros
2017-03-13 11:53 ` Roger Quadros
2017-03-13 11:55 ` [PATCH 0/4] ARM: DRA7: Fix DCAN1 stuck-in-transition Roger Quadros
2017-03-13 11:55 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314154843.GD20572@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=rogerq@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.