All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Benc <jbenc@redhat.com>
To: Matthias Schiffer <mschiffer@universe-factory.net>
Cc: davem@davemloft.net, hannes@stressinduktion.org, pshelar@ovn.org,
	aduyck@mirantis.com, roopa@cumulusnetworks.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] vxlan: fix snooping for link-local IPv6 addresses
Date: Tue, 14 Mar 2017 15:56:56 +0100	[thread overview]
Message-ID: <20170314155656.1446a358@griffin> (raw)
In-Reply-To: <a897a68b6a9994b0f7a1d53f6079f5e04fcec443.1489184335.git.mschiffer@universe-factory.net>

On Fri, 10 Mar 2017 23:39:43 +0100, Matthias Schiffer wrote:
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -941,16 +941,24 @@ static int vxlan_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
>   */
>  static bool vxlan_snoop(struct net_device *dev,
>  			union vxlan_addr *src_ip, const u8 *src_mac,
> -			__be32 vni)
> +			__u32 src_ifindex, __be32 vni)

Just "u32", please. No double underscores for u32 inside the
kernel-only code. (Also in other places in this patch.)

Thanks,

 Jiri

  reply	other threads:[~2017-03-14 14:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 22:39 [PATCH net-next 0/3] VXLAN over IPv6 link-local Matthias Schiffer
2017-03-10 22:39 ` Matthias Schiffer
2017-03-10 22:39 ` [PATCH net-next 1/3] vxlan: don't allow link-local IPv6 local/remote addresses without interface Matthias Schiffer
2017-03-14 14:44   ` Jiri Benc
2017-03-10 22:39 ` [PATCH net-next 2/3] vxlan: fix snooping for link-local IPv6 addresses Matthias Schiffer
2017-03-14 14:56   ` Jiri Benc [this message]
2017-03-10 22:39 ` [PATCH net-next 3/3] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses Matthias Schiffer
2017-03-14 15:28   ` Jiri Benc
2017-03-15 14:29     ` Matthias Schiffer
2017-03-15 15:22       ` Jiri Benc
2017-04-05 16:58         ` Matthias Schiffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170314155656.1446a358@griffin \
    --to=jbenc@redhat.com \
    --cc=aduyck@mirantis.com \
    --cc=davem@davemloft.net \
    --cc=hannes@stressinduktion.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mschiffer@universe-factory.net \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.