From: Petr Mladek <pmladek@suse.com>
To: Aleksey Makarov <aleksey.makarov@linaro.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Hurley <peter@hurleysoftware.com>,
Jiri Slaby <jslaby@suse.com>, Robin Murphy <robin.murphy@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
"Nair, Jayachandran" <Jayachandran.Nair@cavium.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var
Date: Tue, 14 Mar 2017 17:52:44 +0100 [thread overview]
Message-ID: <20170314165244.GH3977@pathway.suse.cz> (raw)
In-Reply-To: <20170302131153.22733-2-aleksey.makarov@linaro.org>
On Thu 2017-03-02 16:11:32, Aleksey Makarov wrote:
> The variable preferred_console is used only inside register_console()
> and its semantics is boolean. It is negative when no console has been
> made preferred.
>
> Make it static bool and rename to has_preferred.
>
> Renaming was suggested by Peter Hurley
>
> Signed-off-by: Aleksey Makarov <aleksey.makarov@linaro.org>
I am sorry for the late reply. I was sick.
The change looks fine to me.
Acked-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2017-03-14 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 13:11 [PATCH v2 0/3] printk: fix double printing with earlycon Aleksey Makarov
2017-03-02 13:11 ` [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var Aleksey Makarov
2017-03-02 14:49 ` Steven Rostedt
2017-03-02 15:59 ` Sergey Senozhatsky
2017-03-14 16:52 ` Petr Mladek [this message]
2017-03-02 13:11 ` [PATCH v2 2/3] printk: rename selected_console -> preferred_console Aleksey Makarov
2017-03-02 15:01 ` Steven Rostedt
2017-03-02 16:09 ` Sergey Senozhatsky
2017-03-15 9:00 ` Petr Mladek
2017-03-02 13:11 ` [PATCH v2 3/3] printk: fix double printing with earlycon Aleksey Makarov
2017-03-02 13:58 ` Aleksey Makarov
2017-03-03 15:49 ` [PATCH v3 " Aleksey Makarov
2017-03-06 14:59 ` Sergey Senozhatsky
2017-03-07 14:54 ` Aleksey Makarov
2017-03-08 5:33 ` Sergey Senozhatsky
2017-03-08 12:59 ` Aleksey Makarov
2017-03-14 16:17 ` [PATCH v2 0/3] " Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314165244.GH3977@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=Jayachandran.Nair@cavium.com \
--cc=aleksey.makarov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.