From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH 0/2] KVM: x86: use pic/ioapic destructor when proper
Date: Wed, 15 Mar 2017 15:58:28 +0800
Message-ID: <20170315075828.GA5955@pxdev.xzpeter.org>
References: <1489560811-32237-1-git-send-email-peterx@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: David Hildenbrand <david@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:46838 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751661AbdCOH6b (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 15 Mar 2017 03:58:31 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id E314C80F63
        for <kvm@vger.kernel.org>; Wed, 15 Mar 2017 07:58:31 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1489560811-32237-1-git-send-email-peterx@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Mar 15, 2017 at 02:53:29PM +0800, Peter Xu wrote:
> A tiny cleanup series for pic/ioapic destruction when vm destroys.
> Please review, Thanks.
> 
> Peter Xu (2):
>   KVM: x86: clear bus pointer when destroyed
>   KVM: x86: use pic/ioapic destructor when destroy vm

NACK. Patch 2 breaks split irqchip.

The old code can live with split irqchip since it's using kfree() and
kfree() allows null pointer. Will repost. Sorry for the noise...

-- peterx