From: Dan Carpenter <dan.carpenter@oracle.com>
To: mshan <educha997@gmail.com>
Cc: gregkh@linuxfoundation.org, mohsinshan1k@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding style Warnings.
Date: Wed, 15 Mar 2017 11:37:53 +0300 [thread overview]
Message-ID: <20170315083753.GX4136@mwanda> (raw)
In-Reply-To: <1489550030-24841-1-git-send-email-mohsinshan1k@gmail.com>
Fix the subject. The subsystem prefix is wrong and it's too vague.
Change it to:
[PATCH] Staging: goldfish: use __func__ instead of embedded function names
On Tue, Mar 14, 2017 at 08:53:50PM -0700, mshan wrote:
> Embedded function names are less appropriate to use when
> refactoring, can cause function renaming. Prefer the use
> of "%s", __func__ to embedded function names
>
> Signed-off-by: mshan <mohsinshan1k@gmail.com>
Please use your legal/formal name as if you were signing a legal
document. Also change the From header on your email to match.
regards,
dan carpenter
prev parent reply other threads:[~2017-03-15 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 3:53 [PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding style Warnings mshan
2017-03-15 8:37 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315083753.GX4136@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=educha997@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsinshan1k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.