Re: [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

["Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>]

On Wed, Mar 15, 2017 at 11:39:07AM +0100, Nélio Laranjeiro wrote:
> Hi Yongseok,
> 
> I did not see this v2, in the future please use the "in-reply-to" in
> addition of the --thread option.
> 
> Please see the comments below,
> 
>[...]
> >  
> > @@ -292,7 +298,11 @@ mlx5_args_check(const char *key, const char *val, void *opaque)
> >  	} else if (strcmp(MLX5_TXQS_MIN_INLINE, key) == 0) {
> >  		priv->txqs_inline = tmp;
> >  	} else if (strcmp(MLX5_TXQ_MPW_EN, key) == 0) {
> > -		priv->mps &= !!tmp; /* Enable MPW only if HW supports */
> > +		priv->mps = !!tmp ? priv->mps : MLX5_MPW_DISABLED;
> > +	} else if (strcmp(MLX5_TXQ_MPW_HDR_DSEG_EN, key) == 0) {
> > +		priv->mpw_hdr_dseg = !!tmp;
> > +	} else if (strcmp(MLX5_TXQ_MAX_INLINE_LEN, key) == 0) {
> > +		priv->txq_max_inline_len = tmp;
> >  	} else if (strcmp(MLX5_TSO, key) == 0) {
> 
> Is it really necessary to let the ConnectX-5 behave in the non enhanced
> feature?
>[...]

Sorry I did not read correctly.  Forget this remark.

Thanks,

-- 
Nélio Laranjeiro
6WIND