From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 6/9] tests: py: add ct helper tests
Date: Wed, 15 Mar 2017 12:46:41 +0100 [thread overview]
Message-ID: <20170315114641.GD24366@breakpoint.cc> (raw)
In-Reply-To: <20170315103933.GA11143@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Tue, Mar 14, 2017 at 08:58:13PM +0100, Florian Westphal wrote:
> > +%cthelp1 type ct helper { type \"ftp\"\; protocol tcp\; };ok
>
> Just a minor syntax nitpick here.
>
> Protocol should be part of the same statement, right? ie.
>
> { type "ftp" protocol tcp ; }
>
> It fundamental to achieve a working configuration. You can send a
> follow up patch to amend this, no problem.
No, I'll change this in patch #1 and will respin the series, thanks
Pablo.
next prev parent reply other threads:[~2017-03-15 11:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 19:58 [PATCH nft 0/9] ct helper set support Florian Westphal
2017-03-14 19:58 ` [PATCH nft 1/9] src: add initial ct helper support Florian Westphal
2017-03-14 19:58 ` [PATCH nft 2/9] evaluate: refactor CMD_OBJ_QUOTA/COUNTER handling Florian Westphal
2017-03-14 19:58 ` [PATCH nft 3/9] src: allow listing all ct helpers Florian Westphal
2017-03-14 19:58 ` [PATCH nft 4/9] src: implement add/create/delete for ct helper objects Florian Westphal
2017-03-14 19:58 ` [PATCH nft 5/9] ct: add conntrack event mask support Florian Westphal
2017-03-14 20:00 ` Florian Westphal
2017-03-15 9:53 ` Pablo Neira Ayuso
2017-03-14 19:58 ` [PATCH nft 6/9] tests: py: add ct helper tests Florian Westphal
2017-03-15 10:39 ` Pablo Neira Ayuso
2017-03-15 11:46 ` Florian Westphal [this message]
2017-03-14 19:58 ` [PATCH nft 7/9] files: provide 'raw' table equivalent Florian Westphal
2017-03-14 19:58 ` [PATCH nft 8/9] doc: ct zone set support Florian Westphal
2017-03-14 19:58 ` [PATCH nft 9/9] doc: helper assignement Florian Westphal
2017-03-15 10:40 ` Pablo Neira Ayuso
2017-03-15 10:35 ` [PATCH nft 0/9] ct helper set support Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315114641.GD24366@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.