From: Thierry Reding <thierry.reding@gmail.com>
To: Mikko Perttunen <cyndis@kapsi.fi>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Stefan Kristiansson <stefank@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 3/3] soc/tegra: bpmp: Implement generic PM domains
Date: Wed, 15 Mar 2017 16:00:36 +0100 [thread overview]
Message-ID: <20170315150036.GC29259@ulmo.ba.sec> (raw)
In-Reply-To: <06005f89-a3fd-ce7d-57f0-e77e866f7e8f@kapsi.fi>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Wed, Mar 15, 2017 at 12:49:47PM +0200, Mikko Perttunen wrote:
> On 14.03.2017 21:15, Thierry Reding wrote:
> > ...
> > +
> > +static inline bool tegra_bpmp_powergate_is_powered(struct tegra_bpmp *bpmp,
> > + unsigned int id)
> > +{
> > + return tegra_bpmp_powergate_get_state(bpmp, id) == PG_STATE_ON;
> > +}
>
> This should also check for PG_STATE_RUNNING and consider that to be on.
> There's this tristate thing for legacy reasons..
Okay, I've made this check for != PG_STATE_OFF to avoid multiple cases.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-03-15 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 19:15 [PATCH 0/3] soc/tegra: bpmp: Generic PM domains for Tegra186 Thierry Reding
[not found] ` <20170314191516.13083-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 19:15 ` [PATCH 1/3] PM / Domains: Allow overriding the ->xlate() callback Thierry Reding
2017-03-14 20:34 ` Jon Hunter
[not found] ` <20d4efbc-b3f1-4d64-0aae-ac51e171a09a-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-03-15 13:36 ` Thierry Reding
2017-03-15 13:43 ` Jon Hunter
2017-03-14 19:15 ` [PATCH 2/3] soc/tegra: bpmp: Update ABI header Thierry Reding
2017-03-14 19:15 ` [PATCH 3/3] soc/tegra: bpmp: Implement generic PM domains Thierry Reding
2017-03-14 20:46 ` Jon Hunter
[not found] ` <709fd66d-b8ca-5cb7-ba58-a64ee3363c96-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-03-15 13:45 ` Thierry Reding
[not found] ` <20170314191516.13083-4-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-15 10:49 ` Mikko Perttunen
2017-03-15 15:00 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315150036.GC29259@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=cyndis@kapsi.fi \
--cc=jonathanh@nvidia.com \
--cc=khilman@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=stefank@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.