[U-Boot] [PATCH] PMIC: TI: TPS65903X errata (SLIA087) code

[Lukasz Majewski <lukma@denx.de>]

On Wed, 15 Mar 2017 09:35:29 -0400
Tom Rini <trini@konsulko.com> wrote:

> On Wed, Mar 15, 2017 at 11:07:34AM +0100, Lukasz Majewski wrote:
> > On Tue, 14 Mar 2017 09:22:02 -0400
> > Tom Rini <trini@konsulko.com> wrote:
> > 
> > > On Fri, Mar 10, 2017 at 11:40:27PM +0100, Lukasz Majewski wrote:
> > > 
> > > > This patch adds code, which comply with TPS65903X errata
> > > > pseudocode described in SLIA087 - "Guide to Using the GPADC in
> > > > TPS65903x and TPS6591x Devices".
> > > > 
> > > > It is enabled by proper Kconfig option, when TI's palmas PMIC
> > > > support is added.
> > > > 
> > > > The TI's e2e thread with test procedure description:
> > > > https://e2e.ti.com/support/power_management/pmu/f/200/p/579649/2130910#2130910
> > > > 
> > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > 
> > > I assume you have hardware that also uses this, so please submit
> > > with it as it's not clear to me when the errata function you add
> > > should be called. 
> > 
> > I'm working on AM57xx based system, which will utilize this.
> > 
> > I wanted to share it early, since it might take some time to make
> > the "devel" code suitable for ML.
> > 
> > Nonetheless, other TI boards can use those fixes if they use this
> > type of PMIC (TPS65903x) despite the lack of my board in ML.
> 
> So, the am57xx EVMs, the dra7xx EVMs and the am57xx compulab SoM?

Yes, if they use this PMIC

> I
> assume you have at least one of the TI EVMs, can you enable it there
> and show how it would be used? 

I had one of them. Now I do have only my custom board(s).

> Is there a case where we would not
> want to be enabling this errata?  

This errata is about GPACD - General Purpose Analog Digital Converter
in PMIC. It is not critical for system booting, but can save some
high-level user's stress when enabled.

For example - he/she will not have to do "dummy" read to have correct
ADC values in the user space Linux program after booting.

> Thanks!
> 

I've added it to 

int board_late_init(void)
{
....
	ret = tps65903x_errata();
	if (ret)
		return ret;
....

}


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170315/4cd6b1e0/attachment.sig>