From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH nf] netfilter: nft_ct: do cleanup work when NFTA_CT_DIRECTION is invalid Date: Wed, 15 Mar 2017 17:15:23 +0100 Message-ID: <20170315161523.GC28159@salvia> References: <1489587728-28318-1-git-send-email-zlpnobody@163.com> <20170315145231.GF24366@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Liping Zhang , netfilter-devel@vger.kernel.org, Liping Zhang To: Florian Westphal Return-path: Received: from mail.us.es ([193.147.175.20]:44022 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbdCOQP2 (ORCPT ); Wed, 15 Mar 2017 12:15:28 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 12291FB44F for ; Wed, 15 Mar 2017 17:15:26 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 03F1ADA870 for ; Wed, 15 Mar 2017 17:15:26 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id BD141DA870 for ; Wed, 15 Mar 2017 17:15:23 +0100 (CET) Content-Disposition: inline In-Reply-To: <20170315145231.GF24366@breakpoint.cc> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Mar 15, 2017 at 03:52:31PM +0100, Florian Westphal wrote: > Liping Zhang wrote: > > From: Liping Zhang > > > > We should jump to invoke __nft_ct_set_destroy() instead of just > > return error. > > > > Fixes: edee4f1e9245 ("netfilter: nft_ct: add zone id set support") > > Signed-off-by: Liping Zhang > > Indeed, good catch, thanks! > > Acked-by: Florian Westphal Applied, thanks.