All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brandon Williams <bmwill@google.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] submodule.c: fix an 'using integer as NULL pointer' warning
Date: Wed, 15 Mar 2017 21:49:07 -0700	[thread overview]
Message-ID: <20170316044907.GI159137@google.com> (raw)
In-Reply-To: <2134ffee-f144-1fb3-7e0e-325fd2873ba9@ramsayjones.plus.com>

On 03/16, Ramsay Jones wrote:
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Brandon,
> 
> If you need to re-roll your 'bw/submodule-is-active' branch, could
> you please squash this into the relevant patch (commit 20d59ab335,
> "submodule: decouple url and submodule existence", 13-03-2017).

Thanks for catching this, I've squashed it into my local branch and I'm
planning on sending out a reroll in a day or so.

> 
> Thanks!
> 
> ATB,
> Ramsay Jones
> 
>  submodule.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/submodule.c b/submodule.c
> index 800283154..a77d11cc4 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -245,7 +245,7 @@ int is_submodule_initialized(const char *path)
>  			argv_array_push(&args, item->string);
>  		}
>  
> -		parse_pathspec(&ps, 0, 0, 0, args.argv);
> +		parse_pathspec(&ps, 0, 0, NULL, args.argv);
>  		ret = match_pathspec(&ps, path, strlen(path), 0, NULL, 1);
>  
>  		argv_array_clear(&args);
> -- 
> 2.12.0

-- 
Brandon Williams

      reply	other threads:[~2017-03-16  4:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16  1:02 [PATCH] submodule.c: fix an 'using integer as NULL pointer' warning Ramsay Jones
2017-03-16  4:49 ` Brandon Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170316044907.GI159137@google.com \
    --to=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.